Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CRITICAL) Wrong key derivation for BIP44 #2186

Closed
a49q258k opened this issue Feb 23, 2017 · 1 comment
Closed

(CRITICAL) Wrong key derivation for BIP44 #2186

a49q258k opened this issue Feb 23, 2017 · 1 comment

Comments

@a49q258k
Copy link

TEST CASE:

Mnemonic fruit wave dwarf banana earth journey tattoo true farm silk olive fence
Passphrase banana

Electrum
m/44'/0'/0'/0/0 17rxURoF96VhmkcEGCj5LNQkmN9HVhWb7F

BitPay/Copay
m/44'/0'/0'/0/0 13EuKhffWkBE2KUwcbkbELZb1MpzbimJ3Y

Also see iancoleman/bip39#58 and https://github.com/bitpay/copay/issues/5667, I am not sure which clients are deriving properly / improperly, but we have a BIP39 mnemonic and passphrase that derives different addresses on different clients

@ecdsa
Copy link
Member

ecdsa commented Feb 23, 2017

"The derivation in Copay (and anything using bitcore-lib) is incorrect. The bug is when there is a leading zero of the private key and the hash during derivation does not include the zero. The BIP32 specification states that the size of the private key is always 32 bytes before it's hashed."

@ecdsa ecdsa closed this as completed Feb 23, 2017
Toporin pushed a commit to Toporin/electrum-satochip that referenced this issue Feb 17, 2022
Servers: Add electroncash.de scalenet server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants