SLIP-0039 wallet recovery #6917
Conversation
|
Why was this never picked up? |
|
@andrewkozlik can you please rebase? |
|
@andrewkozlik please rebase again, thanks. |
|
@ecdsa @SomberNight will you please have a look and provide feedback? |
- fix kivy wizard restore-from-seed - qt seed dialog: disable "next share" if current share is invalid - fix tests: file paths should not depend on $PWD (working dir)
There was a problem hiding this comment.
I've reviewed the changes except for slip39.py which I just glanced over.
Re slip39.py, given the json test vectors file passes, I trust it is correct. Also, thanks for adding test cases to test_wallet_vertical.py.
I wish the changes needed for qt/seed_dialog.py could somehow be encapsulated even more - but that does not seem easy.
There are some minor fixes I've pushed as a follow-up. In particular, not sure if it was deliberate but the UI allowed the user to enter an incorrect share and press "next" - I've changed this as I find it confusing.
Apologies for the delayed review. Thank you for the contribution.
|
Thank you @SomberNight for the review and for the merge! |
Implements #5419.
Note that this PR does not include support for SLIP-0039 in the Kivy GUI.