split out network reqs from wallet.add_input_info, and add "Download input data" cb in qt tx dlg
#8241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wallet.add_input_info() previously had a fallback to download parent
prev txs from the network (after a lookup in wallet.db failed).
wallet.add_input_info() is not async, so the network request cannot
be done cleanly there and was really just a hack.
- tx.add_info_from_wallet() calls wallet.add_input_info() on each txin,
in which case these network requests were done sequentially, not concurrently
- the network part of wallet.add_input_info() is now split out into new method:
txin.add_info_from_network()
- in addition to tx.add_info_from_wallet(), there is now also tx.add_info_from_network()
- callers of old tx.add_info_from_wallet() should now called either
- tx.add_info_from_wallet(), then tx.add_info_from_network(), preferably in that order
- tx.add_info_from_wallet() alone is sufficient if the tx is complete,
or typically when not in a signing context
- callers of wallet.bump_fee and wallet.dscancel are now expected to have already
called tx.add_info_from_network(), as it cannot be done in a non-async context
(but for the common case of all-inputs-are-ismine, bump_fee/dscancel should work regardless)
- PartialTxInput.utxo was moved to the baseclass, TxInput.utxo
ported from https://github.com/Electron-Cash/Electron-Cash/blob/e8bbf8280ccaef95c10cdb1c1cb182cd4b504937/electroncash_gui/qt/util.py (originally added in Electron-Cash@8b8d8a5 ) Co-authored-by: Calin Culianu <calin.culianu@gmail.com> Co-authored-by: SomberNight <somber.night@protonmail.com>
If checked, we download prev (parent) txs from the network, asynchronously. This allows calculating the fee and showing "input addresses". We could also SPV-verify the tx, to fill in missing tx_mined_status (block height, blockhash, timestamp, short ids), but this is not done currently. Note that there is no clean way to do this with electrum protocol 1.4: `blockchain.transaction.get_merkle(tx_hash, height)` requires knowledge of the block height. Loosely based on Electron-Cash@6112fe0
SomberNight
added
topic-wallet 👛
|
it looks cleaner that way :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for the individual commits.
Re the Qt tx dialog, here are some pics for tx
eec306392190ddf956c3a233c764ef17fa4ded81540de9e3e8565ab7edd755df:pics