Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Go < 1.14 #1323

Merged
merged 1 commit into from Feb 1, 2021
Merged

Deprecate Go < 1.14 #1323

merged 1 commit into from Feb 1, 2021

Conversation

@jharshman
Copy link
Collaborator

@jharshman jharshman commented Jan 29, 2021

In accordance with our adopted best practices, the main branch and the
next major release of Cobra will deprecate older and un-maintained
versions of Golang.

fix #1322

@jharshman jharshman self-assigned this Jan 29, 2021
@jharshman jharshman requested review from jpmcb and wfernandes Jan 29, 2021
@jharshman
Copy link
Collaborator Author

@jharshman jharshman commented Jan 29, 2021

@umarcor I would actually like to incorporate some of the changes from #1044. Namely the addition of golangci-lint and the fixes to the issues the linters surface.

Let me know how you would like to proceed with that PR.

@jharshman jharshman added this to the Next milestone Jan 29, 2021
Copy link
Collaborator

@jpmcb jpmcb left a comment

Does this also need changes in go.mod? I see

 go 1.12

Will this need to be updated to 1.14?

@jharshman
Copy link
Collaborator Author

@jharshman jharshman commented Jan 29, 2021

@jpmcb good catch, yes that should be updated as well.

@umarcor
Copy link
Contributor

@umarcor umarcor commented Jan 29, 2021

@jharshman, please, go ahead with this. I will then rebase and cleanup on top of master. Adding golangci-lint and so is not strictly related to this, but it will make it easier if I can focus on >1.11 features only. FTR, I did split the initial golangci-lint into two PRs for keeping >1.11 features isolated. Now, both can be merged again, so I will close one of them.

jpmcb
jpmcb approved these changes Feb 1, 2021
Copy link
Collaborator

@jpmcb jpmcb left a comment

Sweet - Thanks @jharshman looks good to me! 👍

In accordance with our adopted best practices, the main branch and the
next major release of Cobra will deprecate older and un-maintained
versions of Golang.

fix spf13#1322
@jharshman jharshman force-pushed the deprecate-go-lt-1-14 branch from 5ab5cd5 to 16c0de6 Feb 1, 2021
@jharshman
Copy link
Collaborator Author

@jharshman jharshman commented Feb 1, 2021

Merging w/o latest CI run. TravisCI still queuing and takes forever. Seems to be related to their switch from .org to .com.

@jharshman jharshman merged commit 1d71ff0 into spf13:master Feb 1, 2021
1 of 2 checks passed
@umarcor
Copy link
Contributor

@umarcor umarcor commented Feb 2, 2021

@jharshman, unfortunately, I don't think it's a transitory issue. The switch from .org to .com has been going on for 2-3 years. However, they recently changed their pricing model. Free resources for open source projects were significantly reduced, and maintainers need to periodically request additional "credits". Since this projects is in spf13's namespace, I guess that only he can see the state of the credits.

In practice, most open source projects are migrating from Travis CI to somewhere else, mostly GitHub Actions.

anthonyfok added a commit that referenced this issue Feb 10, 2021
…ility

Resolves "v1.1.2 is not semver compliant" due to deprecation of Go version

See #1232 (comment)

This reverts commit 1d71ff0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants