Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR labeler with pull_request_target #1338

Merged
merged 3 commits into from Feb 15, 2021
Merged

Add PR labeler with pull_request_target #1338

merged 3 commits into from Feb 15, 2021

Conversation

@jpmcb
Copy link
Collaborator

@jpmcb jpmcb commented Feb 5, 2021

The github actions/labeler workflow now supports the pull_request_target trigger which will enable us to have labels on incoming PRs that originated from forks.

This was originally a permissions issue with action/labeler since they did not support actions being run directly from forks. This was documented in this issue. This new feature has been documented here

And since this is supported directly by Github, I anticipate this will be a much better collaborator experience vs the periodic-labeler tried in #1112

Closes #1092

Let me know if this needs anything else!

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Feb 5, 2021

CLA assistant check
All committers have signed the CLA.

.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
@umarcor
Copy link
Contributor

@umarcor umarcor commented Feb 7, 2021

@jpmcb, I'd be glad if this was discussed in #952, which has been waiting for feedback from maintainers since ~18 months ago.

Ref: #1323 (comment) #907

.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Show resolved Hide resolved
.github/workflows/labeler.yml Outdated Show resolved Hide resolved
.github/workflows/labeler.yml Outdated Show resolved Hide resolved
@jpmcb jpmcb requested a review from jharshman Feb 14, 2021
@jpmcb jpmcb merged commit b55fa79 into spf13:master Feb 15, 2021
7 checks passed
@jpmcb jpmcb deleted the pr-labeler branch Feb 15, 2021
@marckhouzam marckhouzam mentioned this pull request May 4, 2021
@renovate renovate bot mentioned this pull request Jul 1, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants