Prefer ReplaceAll instead of Replace(..., -1) #1530

WhyNotHugo · 2021-11-08T19:22:12Z

Minor change that gopls pointed out. I think it improves readability a bit.

CLAassistant · 2021-11-08T19:22:21Z

All committers have signed the CLA.

umarcor · 2021-11-08T21:47:57Z

According to https://pkg.go.dev/strings#ReplaceAll, ReplaceAll was added in go 1.12. I guess that's why it was not used before. Nevertheless, 1.12 was EOL in Feb 2020, so I guess it's ok to introduce this change.

WhyNotHugo · 2021-11-10T13:18:40Z

Signing the DCO requires me to grant read-write access to all my gists, commit statuses and webhooks.

I'm okay with the DCO, and agree to its terms for this contributions.

However, I can't grant you write access to all my unrelated projects, I'm sure you'll understand that this doesn't make sense for an external contributor.

The wording above is also rather confusing; @CLAassistant here says I need to sign a CLA, and it says CLA everywhere on public pages, but the text I'm shown when trying to complete the flow is the DCO. I find it a bit discomforting that public content specifies one document, but the signing procedure displays another.

Maybe you want to consider using the this integration instead? -> https://github.com/apps/dco

umarcor · 2021-11-10T13:33:50Z

@WhyNotHugo I understand your concerns, but unfortunately I cannot confirm.

On the one hand, I do not remember signing the CLA or DCO, however, in my PRs that check is shown green. Maybe it's the first contribution only and it then checks the list of previous contributors. Therefore, I'm not sure it is compulsory for your to sign it (use the app).

On the other hand, if I go to https://cla-assistant.io/spf13/cobra?pullRequest=1530 and I click "Sign in with Github to agree", I see the following:

I'm curious about why it's asking you read-write access to all the gists, commit statuses and webhooks.

The wording above is also rather confusing; @CLAassistant here says I need to sign a CLA, and it says CLA everywhere on public pages, but the text I'm shown when trying to complete the flow is the DCO. I find it a bit discomforting that public content specifies one document, but the signing procedure displays another.

Maybe you want to consider using the this integration instead? -> https://github.com/apps/dco

I like this proposal. Maybe you can open an issue about it?

WhyNotHugo · 2021-11-10T14:05:00Z

Maybe it doesn't show up for you because you've already granted permissions? Yeah, I'll open up a separate issue on the topic :)

umarcor · 2021-11-10T14:10:35Z

Maybe it doesn't show up for you because you've already granted permissions?

Interesting... I checked my profile and that app is not found anywhere...

jpmcb · 2021-12-07T23:10:13Z

Hmmmm @WhyNotHugo this is somewhat concerning. I had no idea the CLA / DCO required such wide permissions. Can you open a separate issue, include the screenshot, a short description and we can ping Steve there?

WhyNotHugo · 2021-12-08T16:37:45Z

See #1555.

github-actions · 2022-02-07T00:05:32Z

This PR is being marked as stale due to a long period of inactivity

WhyNotHugo · 2022-02-07T09:39:12Z

Not stale

marckhouzam · 2022-03-17T22:16:17Z

According to https://pkg.go.dev/strings#ReplaceAll, ReplaceAll was added in go 1.12. I guess that's why it was not used before. Nevertheless, 1.12 was EOL in Feb 2020, so I guess it's ok to introduce this change.

What is the oldest version of Go that can be used with Cobra right now? Is it older than 1.12?

umarcor · 2022-03-17T23:45:09Z

@marckhouzam we are testing 1.14 to 1.18 in CI. go.mod declares 1.15: https://github.com/spf13/cobra/blob/master/go.mod#L3.
Deprecating <1.14 was announced in January 2021: #1322. See https://github.com/spf13/cobra/blob/master/CONDUCT.md#backward-compatibility. So, we might announce that <1.17 will be deprecated in the next release.

marckhouzam · 2022-03-18T01:52:53Z

@marckhouzam we are testing 1.14 to 1.18 in CI. go.mod declares 1.15: https://github.com/spf13/cobra/blob/master/go.mod#L3. Deprecating <1.14 was announced in January 2021: #1322.

Thanks @umarcor !

Ok, so using a construct from go 1.12 is perfectly fine.

@WhyNotHugo could you rebase this PR to the latest version of the master branch please?

bash_completions.go

jpmcb

This needs commas removed from the trailing ReplaceAll throughout. Commented on a few but there are others

Running make lint locally should be helpful!

bash_completions.go

doc/man_docs.go

doc/man_docs_test.go

marckhouzam

Thanks @WhyNotHugo
LGTM

I'll leave this for @jpmcb since he also started reviewing it.

jpmcb

LGTM!! Thanks so much for the patience on this one!!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/golang-jwt/jwt/v4](https://togithub.com/golang-jwt/jwt) | require | patch | `v4.4.1` -> `v4.4.2` | | [github.com/spf13/cobra](https://togithub.com/spf13/cobra) | require | minor | `v1.4.0` -> `v1.5.0` | | [github.com/stretchr/testify](https://togithub.com/stretchr/testify) | require | patch | `v1.7.2` -> `v1.7.5` | --- ### Release Notes <details> <summary>golang-jwt/jwt</summary> ### [`v4.4.2`](https://togithub.com/golang-jwt/jwt/releases/tag/v4.4.2) [Compare Source](https://togithub.com/golang-jwt/jwt/compare/v4.4.1...v4.4.2) #### What's Changed - Added MicahParks/keyfunc to extensions by [@oxisto](https://togithub.com/oxisto) in [golang-jwt/jwt#194 - Update link to v4 on pkg.go.dev page by [@polRk](https://togithub.com/polRk) in [golang-jwt/jwt#195 - add installation guidelines to the README file by [@morelmiles](https://togithub.com/morelmiles) in [golang-jwt/jwt#204 - chore: replace ioutil with io and os by [@estensen](https://togithub.com/estensen) in [golang-jwt/jwt#198 - CI check for Go code formatting by [@mfridman](https://togithub.com/mfridman) in [golang-jwt/jwt#206 - Create SECURITY.md by [@mfridman](https://togithub.com/mfridman) in [golang-jwt/jwt#171 - Update SECURITY.md by [@oxisto](https://togithub.com/oxisto) in [golang-jwt/jwt#207 - Fixed integer overflow in NumericDate.MarshalJSON by [@qqiao](https://togithub.com/qqiao) in [golang-jwt/jwt#200 - Claims in rsa_test.go Table Driven Test are Unused by [@gkech](https://togithub.com/gkech) in [golang-jwt/jwt#212 #### New Contributors - [@polRk](https://togithub.com/polRk) made their first contribution in [golang-jwt/jwt#195 - [@morelmiles](https://togithub.com/morelmiles) made their first contribution in [golang-jwt/jwt#204 - [@estensen](https://togithub.com/estensen) made their first contribution in [golang-jwt/jwt#198 - [@qqiao](https://togithub.com/qqiao) made their first contribution in [golang-jwt/jwt#200 - [@gkech](https://togithub.com/gkech) made their first contribution in [golang-jwt/jwt#212 **Full Changelog**: golang-jwt/jwt@v4.4.1...v4.4.2 </details> <details> <summary>spf13/cobra</summary> ### [`v1.5.0`](https://togithub.com/spf13/cobra/releases/tag/v1.5.0) [Compare Source](https://togithub.com/spf13/cobra/compare/v1.4.0...v1.5.0) #### Spring 2022 Release 🌥️ Hello everyone! Welcome to another release of cobra. Completions continue to get better and better. This release adds a few really cool new features. We also continue to patch versions of our dependencies as they become available via dependabot. Happy coding! #### Active help 👐🏼 Shout out to [@marckhouzam](https://togithub.com/marckhouzam) for a big value add: Active Help [spf13/cobra#1482. With active help, a program can provide some inline warnings or hints for users as they hit tab. Now, your CLIs can be even more intuitive to use! Currently active help is only supported for bash V2 and zsh. Marc wrote a whole guide on how to do this, so make sure to give it a good read to learn how you can add this to your cobra code! https://github.com/spf13/cobra/blob/master/active_help.md #### Group flags 🧑🏼‍🤝‍🧑🏼 Cobra now has the ability to mark flags as required or exclusive as a ***group***. Shout out to our newest maintainer [@johnSchnake](https://togithub.com/johnSchnake) for this! [spf13/cobra#1654 Let's say you have a `username` flag that ***MUST*** be partnered with a `password` flag. Well, now, you can enforce those as being required together: ```go rootCmd.Flags().StringVarP(&u, "username", "u", "", "Username (required if password is set)") rootCmd.Flags().StringVarP(&pw, "password", "p", "", "Password (required if username is set)") rootCmd.MarkFlagsRequiredTogether("username", "password") ``` Flags may also be marked as "mutally exclusive" with the `MarkFlagsMutuallyExclusive(string, string ... )` command API. Refer to our [user guide documentation](https://togithub.com/spf13/cobra/blob/master/user_guide.md) for further info! #### Completions 👀 - Add backwards-compatibility tests for legacyArgs() by [@marckhouzam](https://togithub.com/marckhouzam) in [spf13/cobra#1547 - feat: Add how to load completions in your current zsh session by [@ondrejsika](https://togithub.com/ondrejsika) in [spf13/cobra#1608 - Introduce FixedCompletions by [@emersion](https://togithub.com/emersion) in [spf13/cobra#1574 - Add shell completion to flag groups by [@marckhouzam](https://togithub.com/marckhouzam) in [spf13/cobra#1659 - Modify brew prefix path in macOS system by [@imxw](https://togithub.com/imxw) in [spf13/cobra#1719 - perf(bash-v2): use backslash escape string expansion for tab by [@scop](https://togithub.com/scop) in [spf13/cobra#1682 - style(bash-v2): out is not an array variable, do not refer to it as such by [@scop](https://togithub.com/scop) in [spf13/cobra#1681 - perf(bash-v2): standard completion optimizations by [@scop](https://togithub.com/scop) in [spf13/cobra#1683 - style(bash): out is not an array variable, do not refer to it as such by [@scop](https://togithub.com/scop) in [spf13/cobra#1684 - perf(bash-v2): short-circuit descriptionless candidate lists by [@scop](https://togithub.com/scop) in [spf13/cobra#1686 - perf(bash-v2): speed up filtering entries with descriptions by [@scop](https://togithub.com/scop) in [spf13/cobra#1689 - perf(bash-v2): speed up filtering menu-complete descriptions by [@scop](https://togithub.com/scop) in [spf13/cobra#1692 - fix(bash-v2): skip empty completions when filtering descriptions by [@scop](https://togithub.com/scop) in [spf13/cobra#1691 - perf(bash-v2): read directly to COMPREPLY on descriptionless short circuit by [@scop](https://togithub.com/scop) in [spf13/cobra#1700 - fix: Don't complete \_command on zsh by [@twpayne](https://togithub.com/twpayne) in [spf13/cobra#1690 - Improve fish_completions code quality by [@t29kida](https://togithub.com/t29kida) in [spf13/cobra#1515 - Fix handling of descriptions for bash v3 by [@marckhouzam](https://togithub.com/marckhouzam) in [spf13/cobra#1735 - undefined or nil Args default to ArbitraryArgs by [@umarcor](https://togithub.com/umarcor) in [spf13/cobra#1612 - Add Command.SetContext by [@joshcarp](https://togithub.com/joshcarp) in [spf13/cobra#1551 - Wrap printf tab with quotes by [@PapaCharlie](https://togithub.com/PapaCharlie) in [spf13/cobra#1665 #### Documentation 📝 - Fixed typos in completions docs - [@cuishuang](https://togithub.com/cuishuang) [spf13/cobra#1625 - Removed `CHANGELOG.md` as it isn't updated - [@johnSchnake](https://togithub.com/johnSchnake) [spf13/cobra#1634 - Minor typo fix in `shell_completion.md` - [@danieldn](https://togithub.com/danieldn) [spf13/cobra#1678 - Changed branch name in the cobra generator link to 'main' - [@skywalker2909](https://togithub.com/skywalker2909) [spf13/cobra#1645 - Fix Command.Context comment by [@katexochen](https://togithub.com/katexochen) in [spf13/cobra#1639 - Change appropriate links from http:// to https:// where applicable - [@deining](https://togithub.com/deining) [spf13/cobra#1695 #### Testing & CI ⚙️ - Test on Golang 1.18 - [@umarcor](https://togithub.com/umarcor) [spf13/cobra#1635 - Use `RICHGO_FORCE_COLOR` - [@umarcor](https://togithub.com/umarcor) [spf13/cobra#1647 - Adds size labeler GitHub action by [@jpmcb](https://togithub.com/jpmcb) in [spf13/cobra#1610 - Update `stale-bot` settings - [@jpmcb](https://togithub.com/jpmcb) [spf13/cobra#1609 #### Beep boop, bot commits 🤖 - Bumped golangci/golangci-lint-action from 3.1.0 to 3.2.0 - [@dependabot](https://togithub.com/dependabot) [spf13/cobra#1697 - Bump codelytv/pr-size-labeler from 1.8.0 to 1.8.1 - [@dependabot](https://togithub.com/dependabot) [spf13/cobra#1661 - Bump actions/stale from 1 to 5 by [@dependabot](https://togithub.com/dependabot) in [spf13/cobra#1618 - Bump actions/cache from 2 to 3 by [@dependabot](https://togithub.com/dependabot) in [spf13/cobra#1640 - Bump actions/labeler from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [spf13/cobra#1620 - Bump golangci/golangci-lint-action from 2 to 3.1.0 by [@dependabot](https://togithub.com/dependabot) in [spf13/cobra#1615 - Bump actions/checkout from 2 to 3 by [@dependabot](https://togithub.com/dependabot) in [spf13/cobra#1619 - Bump github.com/cpuguy83/go-md2man/v2 from 2.0.1 to 2.0.2 by [@dependabot](https://togithub.com/dependabot) in [spf13/cobra#1688 - Bump actions/setup-go from 2 to 3 by [@dependabot](https://togithub.com/dependabot) in [spf13/cobra#1660 #### Misc 💭 - Use `errors.Is()` to check for errors - [@Luap99](https://togithub.com/Luap99) [spf13/cobra#1730 - Prefer ReplaceAll instead of Replace(..., -1) by [@WhyNotHugo](https://togithub.com/WhyNotHugo) in [spf13/cobra#1530 - Add Kubescape to projects - [@avinashupadhya99](https://togithub.com/avinashupadhya99) [spf13/cobra#1642 - Add Pulumi as a project using cobra by [@iwahbe](https://togithub.com/iwahbe) in [spf13/cobra#1720 - Add Polygon Edge as a project using Cobra by [@zivkovicmilos](https://togithub.com/zivkovicmilos) in [spf13/cobra#1672 Shoutout to *ALL* our contributors (and all the new first time contributors!!) - great work everyone!! Cobra and it's huge impact wouldn't be possible without you 👏🏼 🚀 🐍 **Full Changelog**: spf13/cobra@v1.4.0...v1.5.0 </details> <details> <summary>stretchr/testify</summary> ### [`v1.7.5`](https://togithub.com/stretchr/testify/compare/v1.7.4...v1.7.5) [Compare Source](https://togithub.com/stretchr/testify/compare/v1.7.4...v1.7.5) ### [`v1.7.4`](https://togithub.com/stretchr/testify/compare/v1.7.3...v1.7.4) [Compare Source](https://togithub.com/stretchr/testify/compare/v1.7.3...v1.7.4) ### [`v1.7.3`](https://togithub.com/stretchr/testify/compare/v1.7.2...v1.7.3) [Compare Source](https://togithub.com/stretchr/testify/compare/v1.7.2...v1.7.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on Thursday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, click this checkbox.

…is#1128) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/spf13/cobra](https://togithub.com/spf13/cobra) | require | minor | `v1.4.0` -> `v1.5.0` | --- ### Release Notes <details> <summary>spf13/cobra</summary> ### [`v1.5.0`](https://togithub.com/spf13/cobra/releases/tag/v1.5.0) [Compare Source](https://togithub.com/spf13/cobra/compare/v1.4.0...v1.5.0) #### Spring 2022 Release 🌥️ Hello everyone! Welcome to another release of cobra. Completions continue to get better and better. This release adds a few really cool new features. We also continue to patch versions of our dependencies as they become available via dependabot. Happy coding! #### Active help 👐🏼 Shout out to [@marckhouzam](https://togithub.com/marckhouzam) for a big value add: Active Help [spf13/cobra#1482. With active help, a program can provide some inline warnings or hints for users as they hit tab. Now, your CLIs can be even more intuitive to use! Currently active help is only supported for bash V2 and zsh. Marc wrote a whole guide on how to do this, so make sure to give it a good read to learn how you can add this to your cobra code! https://github.com/spf13/cobra/blob/master/active_help.md #### Group flags 🧑🏼‍🤝‍🧑🏼 Cobra now has the ability to mark flags as required or exclusive as a ***group***. Shout out to our newest maintainer [@johnSchnake](https://togithub.com/johnSchnake) for this! [spf13/cobra#1654 Let's say you have a `username` flag that ***MUST*** be partnered with a `password` flag. Well, now, you can enforce those as being required together: ```go rootCmd.Flags().StringVarP(&u, "username", "u", "", "Username (required if password is set)") rootCmd.Flags().StringVarP(&pw, "password", "p", "", "Password (required if username is set)") rootCmd.MarkFlagsRequiredTogether("username", "password") ``` Flags may also be marked as "mutally exclusive" with the `MarkFlagsMutuallyExclusive(string, string ... )` command API. Refer to our [user guide documentation](https://togithub.com/spf13/cobra/blob/master/user_guide.md) for further info! #### Completions 👀 - Add backwards-compatibility tests for legacyArgs() by [@marckhouzam](https://togithub.com/marckhouzam) in [spf13/cobra#1547 - feat: Add how to load completions in your current zsh session by [@ondrejsika](https://togithub.com/ondrejsika) in [spf13/cobra#1608 - Introduce FixedCompletions by [@emersion](https://togithub.com/emersion) in [spf13/cobra#1574 - Add shell completion to flag groups by [@marckhouzam](https://togithub.com/marckhouzam) in [spf13/cobra#1659 - Modify brew prefix path in macOS system by [@imxw](https://togithub.com/imxw) in [spf13/cobra#1719 - perf(bash-v2): use backslash escape string expansion for tab by [@scop](https://togithub.com/scop) in [spf13/cobra#1682 - style(bash-v2): out is not an array variable, do not refer to it as such by [@scop](https://togithub.com/scop) in [spf13/cobra#1681 - perf(bash-v2): standard completion optimizations by [@scop](https://togithub.com/scop) in [spf13/cobra#1683 - style(bash): out is not an array variable, do not refer to it as such by [@scop](https://togithub.com/scop) in [spf13/cobra#1684 - perf(bash-v2): short-circuit descriptionless candidate lists by [@scop](https://togithub.com/scop) in [spf13/cobra#1686 - perf(bash-v2): speed up filtering entries with descriptions by [@scop](https://togithub.com/scop) in [spf13/cobra#1689 - perf(bash-v2): speed up filtering menu-complete descriptions by [@scop](https://togithub.com/scop) in [spf13/cobra#1692 - fix(bash-v2): skip empty completions when filtering descriptions by [@scop](https://togithub.com/scop) in [spf13/cobra#1691 - perf(bash-v2): read directly to COMPREPLY on descriptionless short circuit by [@scop](https://togithub.com/scop) in [spf13/cobra#1700 - fix: Don't complete \_command on zsh by [@twpayne](https://togithub.com/twpayne) in [spf13/cobra#1690 - Improve fish_completions code quality by [@t29kida](https://togithub.com/t29kida) in [spf13/cobra#1515 - Fix handling of descriptions for bash v3 by [@marckhouzam](https://togithub.com/marckhouzam) in [spf13/cobra#1735 - undefined or nil Args default to ArbitraryArgs by [@umarcor](https://togithub.com/umarcor) in [spf13/cobra#1612 - Add Command.SetContext by [@joshcarp](https://togithub.com/joshcarp) in [spf13/cobra#1551 - Wrap printf tab with quotes by [@PapaCharlie](https://togithub.com/PapaCharlie) in [spf13/cobra#1665 #### Documentation 📝 - Fixed typos in completions docs - [@cuishuang](https://togithub.com/cuishuang) [spf13/cobra#1625 - Removed `CHANGELOG.md` as it isn't updated - [@johnSchnake](https://togithub.com/johnSchnake) [spf13/cobra#1634 - Minor typo fix in `shell_completion.md` - [@danieldn](https://togithub.com/danieldn) [spf13/cobra#1678 - Changed branch name in the cobra generator link to 'main' - [@skywalker2909](https://togithub.com/skywalker2909) [spf13/cobra#1645 - Fix Command.Context comment by [@katexochen](https://togithub.com/katexochen) in [spf13/cobra#1639 - Change appropriate links from http:// to https:// where applicable - [@deining](https://togithub.com/deining) [spf13/cobra#1695 #### Testing & CI ⚙️ - Test on Golang 1.18 - [@umarcor](https://togithub.com/umarcor) [spf13/cobra#1635 - Use `RICHGO_FORCE_COLOR` - [@umarcor](https://togithub.com/umarcor) [spf13/cobra#1647 - Adds size labeler GitHub action by [@jpmcb](https://togithub.com/jpmcb) in [spf13/cobra#1610 - Update `stale-bot` settings - [@jpmcb](https://togithub.com/jpmcb) [spf13/cobra#1609 #### Beep boop, bot commits 🤖 - Bumped golangci/golangci-lint-action from 3.1.0 to 3.2.0 - [@dependabot](https://togithub.com/dependabot) [spf13/cobra#1697 - Bump codelytv/pr-size-labeler from 1.8.0 to 1.8.1 - [@dependabot](https://togithub.com/dependabot) [spf13/cobra#1661 - Bump actions/stale from 1 to 5 by [@dependabot](https://togithub.com/dependabot) in [spf13/cobra#1618 - Bump actions/cache from 2 to 3 by [@dependabot](https://togithub.com/dependabot) in [spf13/cobra#1640 - Bump actions/labeler from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [spf13/cobra#1620 - Bump golangci/golangci-lint-action from 2 to 3.1.0 by [@dependabot](https://togithub.com/dependabot) in [spf13/cobra#1615 - Bump actions/checkout from 2 to 3 by [@dependabot](https://togithub.com/dependabot) in [spf13/cobra#1619 - Bump github.com/cpuguy83/go-md2man/v2 from 2.0.1 to 2.0.2 by [@dependabot](https://togithub.com/dependabot) in [spf13/cobra#1688 - Bump actions/setup-go from 2 to 3 by [@dependabot](https://togithub.com/dependabot) in [spf13/cobra#1660 #### Misc 💭 - Use `errors.Is()` to check for errors - [@Luap99](https://togithub.com/Luap99) [spf13/cobra#1730 - Prefer ReplaceAll instead of Replace(..., -1) by [@WhyNotHugo](https://togithub.com/WhyNotHugo) in [spf13/cobra#1530 - Add Kubescape to projects - [@avinashupadhya99](https://togithub.com/avinashupadhya99) [spf13/cobra#1642 - Add Pulumi as a project using cobra by [@iwahbe](https://togithub.com/iwahbe) in [spf13/cobra#1720 - Add Polygon Edge as a project using Cobra by [@zivkovicmilos](https://togithub.com/zivkovicmilos) in [spf13/cobra#1672 Shoutout to *ALL* our contributors (and all the new first time contributors!!) - great work everyone!! Cobra and it's huge impact wouldn't be possible without you 👏🏼 🚀 🐍 **Full Changelog**: spf13/cobra@v1.4.0...v1.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-showcase).

github-actions bot added area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli area/docs-generation Generation of docs via Cobra labels Nov 8, 2021

umarcor approved these changes Nov 8, 2021

View reviewed changes

umarcor mentioned this pull request Nov 8, 2021

Fall release 🍁 - 2021 #1496

Closed

jpmcb mentioned this pull request Dec 7, 2021

cla-assistant requires excessive permissions cla-assistant/cla-assistant#810

Open

WhyNotHugo mentioned this pull request Dec 8, 2021

CLA bot requires to broad permissions #1555

Open

umarcor mentioned this pull request Dec 14, 2021

Winter 2022 release ❄️ #1565

Closed

github-actions bot added the kind/stale label Feb 7, 2022

umarcor mentioned this pull request Mar 10, 2022

Spring 2022 release 🌼 #1626

Closed

WhyNotHugo force-pushed the replace-all branch from 84cf71f to dcf6fbf Compare March 18, 2022 13:07

marckhouzam reviewed Mar 19, 2022

View reviewed changes

bash_completions.go Outdated Show resolved Hide resolved

github-actions bot removed the kind/stale label Mar 26, 2022

jpmcb removed the area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli label Mar 29, 2022

jpmcb requested changes Mar 29, 2022

View reviewed changes

bash_completions.go Outdated Show resolved Hide resolved

doc/man_docs.go Outdated Show resolved Hide resolved

doc/man_docs_test.go Outdated Show resolved Hide resolved

doc/man_docs_test.go Outdated Show resolved Hide resolved

jpmcb added area/shell-completion All shell completions area/go General Go things, like go.mod or go.sum kind/cleanup General cleanup of code, issues, etc. labels Mar 29, 2022

Prefer ReplaceAll instead of Replace(..., -1)

dd9b61d

WhyNotHugo force-pushed the replace-all branch from dcf6fbf to dd9b61d Compare April 4, 2022 09:55

github-actions bot added size/M Denotes a PR that chanes 24-99 lines and removed area/shell-completion All shell completions labels Apr 4, 2022

marckhouzam approved these changes Apr 4, 2022

View reviewed changes

marckhouzam added the lgtm Denotes "looks good to me" from maintainers and signals other collaboratores that a PR is ready label Apr 4, 2022

marckhouzam added this to the 1.5.0 milestone Apr 4, 2022

umarcor mentioned this pull request Apr 24, 2022

fix: generate docs for commands containing slashes #1675

Open

jpmcb approved these changes May 14, 2022

View reviewed changes

jpmcb merged commit 25f5bb5 into spf13:master May 14, 2022

WhyNotHugo deleted the replace-all branch May 18, 2022 13:46

WhyNotHugo restored the replace-all branch May 18, 2022 13:47

WhyNotHugo deleted the replace-all branch May 18, 2022 13:47

WhyNotHugo restored the replace-all branch May 18, 2022 13:47

Prefer ReplaceAll instead of Replace(..., -1) #1530

Prefer ReplaceAll instead of Replace(..., -1) #1530

WhyNotHugo commented Nov 8, 2021

CLAassistant commented Nov 8, 2021 •

edited

umarcor commented Nov 8, 2021

WhyNotHugo commented Nov 10, 2021

umarcor commented Nov 10, 2021

WhyNotHugo commented Nov 10, 2021

umarcor commented Nov 10, 2021

jpmcb commented Dec 7, 2021 •

edited

WhyNotHugo commented Dec 8, 2021

github-actions bot commented Feb 7, 2022

WhyNotHugo commented Feb 7, 2022 via email

marckhouzam commented Mar 17, 2022

umarcor commented Mar 17, 2022

marckhouzam commented Mar 18, 2022

jpmcb left a comment

marckhouzam left a comment

jpmcb left a comment

Prefer ReplaceAll instead of Replace(..., -1) #1530

Prefer ReplaceAll instead of Replace(..., -1) #1530

Conversation

WhyNotHugo commented Nov 8, 2021

CLAassistant commented Nov 8, 2021 • edited

umarcor commented Nov 8, 2021

WhyNotHugo commented Nov 10, 2021

umarcor commented Nov 10, 2021

WhyNotHugo commented Nov 10, 2021

umarcor commented Nov 10, 2021

jpmcb commented Dec 7, 2021 • edited

WhyNotHugo commented Dec 8, 2021

github-actions bot commented Feb 7, 2022

WhyNotHugo commented Feb 7, 2022 via email

marckhouzam commented Mar 17, 2022

umarcor commented Mar 17, 2022

marckhouzam commented Mar 18, 2022

jpmcb left a comment

Choose a reason for hiding this comment

marckhouzam left a comment

Choose a reason for hiding this comment

jpmcb left a comment

Choose a reason for hiding this comment

CLAassistant commented Nov 8, 2021 •

edited

jpmcb commented Dec 7, 2021 •

edited