Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #269 #361

Closed
wants to merge 2 commits into from
Closed

Fix #269 #361

wants to merge 2 commits into from

Conversation

nouney
Copy link

@nouney nouney commented Nov 7, 2016

This PR fixes #269.

Cobra generator will automatically use a camelCase version of the command name if it is needed.

By example:
$ cobra add camel-case
will generate:

...
// camelCaseCmd represents the camel-case command
var camelCaseCmd = &cobra.Command{
        Use:   "camel-case",
        Short: "A brief description of your command",
...

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ nouney
❌ Valentin Tjoncke


nouney, Valentin Tjoncke seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@nouney
Copy link
Author

nouney commented Nov 8, 2016

What's the problem with Travis?

@bengadbois
Copy link
Contributor

You need to gofmt your changes, so that diff -u <(echo -n) <(gofmt -d -s .) will return nothing

@nouney nouney closed this Dec 8, 2016
@nouney nouney deleted the fix-gh-269 branch December 8, 2016 12:28
@nouney
Copy link
Author

nouney commented Dec 8, 2016

Nevermind, CLA is just a pain in the ass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding commands with dashes("-") in the name generates bad code
3 participants