Skip to content

Conversation

zaneb
Copy link
Contributor

@zaneb zaneb commented Apr 2, 2018

Give users the option to have apidoc generate a page-per-module instead
of a page-per-package.

@stmcginnis
Copy link

This would help keep Cinder docs consistent with the existing doc output. I have not had a chance to test it out yet, but the code looks good, and just want to state support for the idea.

Copy link
Member

@stephenfin stephenfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change needed. Otherwise this is a-OK by me.

app.add_config_value('apidoc_module_dir', None, 'env', [str])
app.add_config_value('apidoc_output_dir', 'api', 'env', [str])
app.add_config_value('apidoc_excluded_paths', [], 'env', [[str]])
app.add_config_value('apidoc_separate_modules', False, 'env', [[bool]])
Copy link
Member

@stephenfin stephenfin Apr 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/[[bool]]/[bool]/

(this is a type check, and what's there means "list of bools" when I guess we just want a single bool)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and fixed this. Also added some tests along the way.

Give users the option to have apidoc generate a page-per-module instead
of a page-per-package.

Signed-off-by: Zane Bitter <zbitter@redhat.com>
Signed-off-by: Stephen Finucane <stephen@that.guru>
@stephenfin stephenfin merged commit ff049bb into sphinx-contrib:master Apr 3, 2018
@zaneb
Copy link
Contributor Author

zaneb commented Apr 3, 2018

Awesome, thanks @stephenfin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants