Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lookup table for multi-word key names (kbd role) #10962

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

textshell
Copy link
Contributor

It seems the original PR adding multi word key support forgot to add commas and python helpfully just concatenated the strings instead of building the required tuples.

@textshell
Copy link
Contributor Author

CI failure seems unrelated, not sure what is happening there.

@textshell
Copy link
Contributor Author

rebased to current master to clear CI troubles.

Can i do anything else to help getting this merged?

@AA-Turner AA-Turner changed the title html: kbd role: Fix missing commas in lookup table for multi word key names. Fix lookup table for multi-word key names (kbd role) Dec 30, 2022
@AA-Turner AA-Turner merged commit aa2fa38 into sphinx-doc:master Dec 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants