Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LaTeX] For 'lualatex' with French, use babel LaTeX package as default, as for 'xelatex', and not polyglossia. #12557

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

jfbu
Copy link
Contributor

@jfbu jfbu commented Jul 13, 2024

Fix #12410

As I consider this a bugfix I did not register it as an "incompatible change" in CHANGES. I think French Sphinx 'lualatex' users either do not care or have their conf.py already set to use the babel LaTeX package.

@jfbu jfbu added this to the 7.4.0 milestone Jul 13, 2024
@jfbu jfbu mentioned this pull request Jul 13, 2024
@AA-Turner AA-Turner merged commit e49e293 into sphinx-doc:master Jul 13, 2024
21 checks passed
@jfbu jfbu deleted the lualatex_french_12410 branch July 13, 2024 09:34
@n-peugnet
Copy link
Contributor

+1
I use babel with 'lualatex' in French Sphinx doc since 2 years and did not notice any issue, but I don't remember why I made this choice to begin with, and my commit message is not helpful 😅

@jfbu
Copy link
Contributor Author

jfbu commented Jul 13, 2024

Your commit message does say indeed "Use for sure babel" 😃. The most visible change I think is in the rendering of lists, which adhere more closely with babel to French typographical standards.

@n-peugnet
Copy link
Contributor

The most visible change I think is in the rendering of lists

Ah yes! You're right, I remember now.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants