Add new confval "author" and use it for lazy evaluation #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
commented
Jan 29, 2018
CHANGES
Outdated
| @@ -20,6 +23,7 @@ Features added | |||
| * Add :event:`config-inited` event | |||
| * Add ``sphinx.config.Any`` to represent the config value accepts any type of | |||
| value | |||
| * Add :confval:`author` as a configuration value | |||
There was a problem hiding this comment.
So far, author is defined as local variable in conf.py.
This enables all of Sphinx modules can refer it.
tk0miya
force-pushed
the
register_author_as_confval
branch
from
4fc3f92
to
41769f1
Compare
tk0miya
commented
Jan 30, 2018
| @@ -231,9 +231,9 @@ def setup(app): | |||
| app.add_config_value('epub_theme', 'epub', 'html') | |||
| app.add_config_value('epub_theme_options', {}, 'html') | |||
| app.add_config_value('epub_title', lambda self: self.html_title, 'html') | |||
| app.add_config_value('epub_author', 'unknown', 'html') | |||
| app.add_config_value('epub_author', lambda self: self.author, 'html') | |||
There was a problem hiding this comment.
This is same as what quickstart does.
sphinx/sphinx/templates/quickstart/conf.py_t
Lines 173 to 177 in 77ae424
So I will be able to omit them from conf.py.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
author