Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #4885 #4887

Merged
merged 1 commit into from Apr 23, 2018
Merged

Fix issue #4885 #4887

merged 1 commit into from Apr 23, 2018

Conversation

knorth55
Copy link
Contributor

@knorth55 knorth55 commented Apr 23, 2018

Subject: Fix issue reported in #4885

Feature or Bugfix

  • Bugfix

Purpose

Detail

  • self.env is not defined
    • self.env -> env
  • modules[modname] is tuple
    • modules[modname] -> modules[modname][0]

Relates

@codecov
Copy link

codecov bot commented Apr 23, 2018

Codecov Report

Merging #4887 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4887      +/-   ##
==========================================
+ Coverage   82.17%   82.18%   +<.01%     
==========================================
  Files         286      291       +5     
  Lines       38005    38326     +321     
  Branches     5878     5932      +54     
==========================================
+ Hits        31230    31497     +267     
- Misses       5465     5511      +46     
- Partials     1310     1318       +8
Impacted Files Coverage Δ
sphinx/domains/python.py 76% <ø> (ø) ⬆️
sphinx/apidoc.py 0% <0%> (ø)
sphinx/errors.py 70% <0%> (ø)
sphinx/search/__init__.py 96% <0%> (ø)
sphinx/quickstart.py 0% <0%> (ø)
sphinx/__init__.py 57.5% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 985886a...3735ba3. Read the comment docs.

@tk0miya tk0miya merged commit 5909ccf into sphinx-doc:master Apr 23, 2018
@tk0miya
Copy link
Member

tk0miya commented Apr 23, 2018

Absolutely right.
Thank you for your work!

tk0miya added a commit that referenced this pull request Apr 23, 2018
@knorth55 knorth55 deleted the fix-issue-4885 branch April 23, 2018 16:35
eleurent added a commit to Farama-Foundation/HighwayEnv that referenced this pull request Apr 25, 2018
Sphinx 1.7.3 was released 3 days ago: https://github.com/sphinx-doc/sphinx/releases

It contains a bug (issue #4885) which prevents doc generation. The fix is here sphinx-doc/sphinx#4887 but we must wait for its integration in a future 1.7.4 release
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants