Fix references to production names. #8239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user tries to align production rules, Sphinx gets confused by
spaces around leading tokens. In the following, references to mygroup:bad1
and mygroup:bad2 are missing, while the one to mygroup:correct is present.
.. productionlist:: mygroup
correct: `correct` | `bad1` | `bad2`
bad1 : `correct` | `bad1` | `bad2`
bad2: `correct` | `bad1` | `bad2`
Since it is useful to be able to align colons in a production list, this
commit systematically strips leading and trailing whitespaces from the
production name.
|
Fair enough. Thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
When the user tries to align production rules, Sphinx gets confused by spaces around leading tokens. In the following, references to
mygroup:bad1andmygroup:bad2are missing, while the one tomygroup:correctis present.Since it is useful to be able to align colons in a production list, this commit systematically strips leading and trailing whitespaces from the production name.