-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow production lists to refer to tokens from other production groups. #8247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Could you add testcases for this new syntax?
I am a bit confused with the testing framework. I suppose I can add some testcases to |
Outside production lists, syntax "`foo:bar`" already makes it possible to refer to the production "bar" of group "foo". This commit offers the same feature inside production lists. Similarly to the reference syntax, prefixing with a tilde prevents the group from being displayed. This commit also makes it possible to use "`:bar`" to refer to production "bar" from a production list without a group name. This is especially useful when one has a main (unnamed) grammar and one or several named extensions that need to refer to it.
88813d5
to
c55be66
Compare
This is a testcase that corresponds with It's okay to modify them or to add new pair of project under |
c55be66
to
e79656d
Compare
e79656d
to
ffacb2c
Compare
Thanks for the help. It seemed a bit too frail and tedious to parse the HTML output. (Contrarily to the other tests for |
Thank you for your work. LGTM! |
Note: I was wrongly labeled this as "4.0.0". But it's unexpected. |
Feature or Bugfix
Purpose
Outside production lists, syntax
`foo:bar`
already makes it possible to refer to the productionbar
of groupfoo
. This commit offers the same feature inside production lists. Similarly to the reference syntax, prefixing with a tilde prevents the group from being displayed.This commit also makes it possible to use
`:bar`
to refer to productionbar
from a production list without a group name. This is especially useful when one has a main (unnamed) grammar and one or several named extensions that need to refer to it.