Skip to content

Conversation

adamtheturtle
Copy link
Contributor

I use this extension and another extension which adds ulem. My Sphinx build gives: WARNING: latex package 'ulem' already included.

I use this extension and another extension which adds `ulem`. My Sphinx build gives: `WARNING: latex package 'ulem' already included`.
Copy link
Member

@SilverRainZ SilverRainZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you please update the changelog?

@adamtheturtle
Copy link
Contributor Author

Thank you for looking @SilverRainZ . I have had a go at that

@SilverRainZ SilverRainZ merged commit bb8896b into sphinx-notes:master Oct 2, 2025
1 check passed
@SilverRainZ
Copy link
Member

Get a error after merge this PR:

  Traceback
  =========
  
      Traceback (most recent call last):
        File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/sphinx/cmd/build.py", line 414, in build_main
          app = Sphinx(
                ^^^^^^^
        File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/sphinx/application.py", line 291, in __init__
          self.setup_extension(extension)
        File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/sphinx/application.py", line 489, in setup_extension
          self.registry.load_extension(self, extname)
        File "/opt/hostedtoolcache/Python/3.12.11/x64/lib/python3.12/site-packages/sphinx/registry.py", line 560, in load_extension
          metadata = setup(app)
                     ^^^^^^^^^^
        File "/home/runner/work/strike/strike/src/sphinxnotes/strike/__init__.py", line 84, in setup
          if not app.has_latex_package(latex_package):
                 ^^^^^^^^^^^^^^^^^^^^^
      AttributeError: 'Sphinx' object has no attribute 'has_latex_package'. Did you mean: 'add_latex_package'?

See also https://github.com/sphinx-notes/strike/actions/runs/18186375432/job/51771395324

@adamtheturtle
Copy link
Contributor Author

Apologies, I'll submit a fix!

SilverRainZ pushed a commit that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants