This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
Always add parseTime=true for mysql query string #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisal-memon
requested review from
marcofranssen,
kfox1111,
developer-guy,
dfeldman,
mrsabath and
edwbuck
as code owners
|
Could you show the printout of the template in the PR description. Looks good, but hard to judge without seeing the result. |
|
If it really is always needed, I'm good with it. Are there times where it may not? If you say, point it against vitess does it still need the flag? It would be good to get a confirmation with the spire devs on this flag if not already done? |
kfox1111
reviewed
Jun 17, 2023
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
|
marcofranssen
added a commit
that referenced
this pull request
Jun 22, 2023
marcofranssen
pushed a commit
that referenced
this pull request
Jun 22, 2023
marcofranssen
added a commit
that referenced
this pull request
Jun 27, 2023
* f4c421a Ensure the released OCI artifact is also captured in rekor * 386e736 Bump sigstore/cosign-installer from 3.0.5 to 3.1.0 (#368) * 99e01c6 Bump spire-controller-manager from 0.2.2 to 0.2.3 (#367) * 4dccb0d Bump spire Helm Chart version from 0.9.0 to 0.9.1 (#365) * 8409674 Fix the init container flags of the statefulset (#366) * 3b66660 add missing federatesWith option (#361) * 0533d92 fixes missing template (#362) * 1333b6a Always add parseTime=true for mysql query string (#352) * ac3be71 Bump test chart dependencies (#358) Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen
added a commit
that referenced
this pull request
Jun 28, 2023
* f4c421a Ensure the released OCI artifact is also captured in rekor * 386e736 Bump sigstore/cosign-installer from 3.0.5 to 3.1.0 (#368) * 99e01c6 Bump spire-controller-manager from 0.2.2 to 0.2.3 (#367) * 4dccb0d Bump spire Helm Chart version from 0.9.0 to 0.9.1 (#365) * 8409674 Fix the init container flags of the statefulset (#366) * 3b66660 add missing federatesWith option (#361) * 0533d92 fixes missing template (#362) * 1333b6a Always add parseTime=true for mysql query string (#352) * ac3be71 Bump test chart dependencies (#358) Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
parseTime=trueis not present spire server will error. This pr ensures that it is always present when mysql db is used, rather than leaving it to use to add it tooptions:.