Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

add missing federatesWith option #361

Merged
merged 1 commit into from
Jun 22, 2023
Merged

add missing federatesWith option #361

merged 1 commit into from
Jun 22, 2023

Conversation

drewwells
Copy link
Contributor

@drewwells drewwells commented Jun 22, 2023 •
edited
Loading

DEMO

spire-server-0 -- spire-server entry show -spiffeID spiffe://box-4.example.com/ns/dwells/sa/dwells-rc-realm-client
Defaulted container "spire-server" out of: spire-server, spire-controller-manager, wait (init)
Found 1 entry
Entry ID         : 09301666-010e-4ba9-9dcb-44370d4e49e4
SPIFFE ID        : spiffe://box-4.example.com/ns/dwells/sa/dwells-rc-realm-client
Parent ID        : spiffe://box-4.example.com/spire/agent/k8s_psat/example-cluster/ff93872d-791f-4bf3-a532-475775d03d3e
Revision         : 0
X509-SVID TTL    : default
JWT-SVID TTL     : default
Selector         : k8s:pod-uid:40e0bcad-6ec8-460b-a839-659654549d7a
FederatesWith    : box-3.example.com

@drewwells drewwells force-pushed the federatesWith branch 3 times, most recently from f316913 to d26915d Compare June 22, 2023 05:43
@marcofranssen marcofranssen added the enhancement New feature or request label Jun 22, 2023
@drewwells @marcofranssen
add missing federatesWith option
70eb085 
Signed-off-by: Drew Wells <dwells@infoblox.com>
marcofranssen
marcofranssen approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@marcofranssen marcofranssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@faisal-memon faisal-memon merged commit 3b66660 into spiffe:main Jun 22, 2023
@marcofranssen marcofranssen added this to the 0.10.0 milestone Jun 22, 2023
@drewwells drewwells deleted the federatesWith branch June 27, 2023 00:50
marcofranssen added a commit that referenced this pull request Jun 27, 2023
@marcofranssen
Bump spire Helm Chart version from 0.9.1 to 0.10.0
ab3d422 
* f4c421a Ensure the released OCI artifact is also captured in rekor
* 386e736 Bump sigstore/cosign-installer from 3.0.5 to 3.1.0 (#368)
* 99e01c6 Bump spire-controller-manager from 0.2.2 to 0.2.3 (#367)
* 4dccb0d Bump spire Helm Chart version from 0.9.0 to 0.9.1 (#365)
* 8409674 Fix the init container flags of the statefulset (#366)
* 3b66660 add missing federatesWith option (#361)
* 0533d92 fixes missing template (#362)
* 1333b6a Always add parseTime=true for mysql query string (#352)
* ac3be71 Bump test chart dependencies (#358)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
@marcofranssen marcofranssen mentioned this pull request Jun 27, 2023
Merged
marcofranssen added a commit that referenced this pull request Jun 28, 2023
@marcofranssen
Bump spire Helm Chart version from 0.9.1 to 0.10.0
5500d36 
* f4c421a Ensure the released OCI artifact is also captured in rekor
* 386e736 Bump sigstore/cosign-installer from 3.0.5 to 3.1.0 (#368)
* 99e01c6 Bump spire-controller-manager from 0.2.2 to 0.2.3 (#367)
* 4dccb0d Bump spire Helm Chart version from 0.9.0 to 0.9.1 (#365)
* 8409674 Fix the init container flags of the statefulset (#366)
* 3b66660 add missing federatesWith option (#361)
* 0533d92 fixes missing template (#362)
* 1333b6a Always add parseTime=true for mysql query string (#352)
* ac3be71 Bump test chart dependencies (#358)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faisal-memon faisal-memon faisal-memon approved these changes

@marcofranssen marcofranssen marcofranssen approved these changes

@kfox1111 kfox1111 Awaiting requested review from kfox1111 kfox1111 is a code owner

@developer-guy developer-guy Awaiting requested review from developer-guy

@dfeldman dfeldman Awaiting requested review from dfeldman

@mrsabath mrsabath Awaiting requested review from mrsabath

@edwbuck edwbuck Awaiting requested review from edwbuck

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@drewwells @marcofranssen @faisal-memon