Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make backend use OIDC Discovery for jwks URL #370

Closed
maia-iyer opened this issue Mar 19, 2024 · 1 comment · Fixed by #393
Closed

Make backend use OIDC Discovery for jwks URL #370

maia-iyer opened this issue Mar 19, 2024 · 1 comment · Fixed by #393
Assignees
Labels
backend Tornjak API (Backend) IAM
Milestone

Comments

@maia-iyer
Copy link
Collaborator

Currently we pass the jwks URL directly to the backend via the config

this is not standard - instead giving the OIDC discovery URL would be more standard, where the backend automatically finds the jwks url

@maia-iyer maia-iyer added the backend Tornjak API (Backend) label Mar 19, 2024
@maia-iyer maia-iyer added this to the 1.6.x milestone Mar 19, 2024
@maia-iyer maia-iyer self-assigned this Mar 19, 2024
@maia-iyer maia-iyer added the IAM label Mar 19, 2024
@maia-iyer
Copy link
Collaborator Author

https://pkg.go.dev/github.com/pardot/oidc/discovery#NewClient

We can carry out OIDC discovery using this library

maia-iyer added a commit that referenced this issue Apr 4, 2024
…#370) (#393)

* Modify JWKS URL in config to Issuer URL for OIDC Discovery in Backend

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Update tests

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* Lint fixes

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* remove accidental swp file

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

* added documentation

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

---------

Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Tornjak API (Backend) IAM
Projects
None yet
1 participant