Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving frontend to production #185

Merged
merged 4 commits into from
May 2, 2023
Merged

Conversation

mamy-CS
Copy link
Collaborator

@mamy-CS mamy-CS commented May 2, 2023

This solves #177

Mohammed Abdi added 2 commits April 27, 2023 13:32
Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local>
Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local>
@mamy-CS mamy-CS added this to the 1.2.x milestone May 2, 2023
@mamy-CS mamy-CS self-assigned this May 2, 2023
Copy link
Collaborator

@mrsabath mrsabath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works fine, it would be a great improvement! Excited to see it working :)
LGTM

Mohammed Abdi added 2 commits May 2, 2023 10:17
Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
@mrsabath mrsabath merged commit 8f5a27e into spiffe:v1.2.0 May 2, 2023
mamy-CS added a commit to mamy-CS/tornjak-public that referenced this pull request May 3, 2023
* break into two builds and reduce fe image to 781mb

Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local>

* moving to production image size reduced to 178mb

Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local>

* dynamically changing container port

Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>

* adding docker compose

Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>

---------

Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local>
Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local>
Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
mrsabath pushed a commit that referenced this pull request May 3, 2023
* break into two builds and reduce fe image to 781mb

Signed-off-by: Mohammed Abdi <mohammma@usc.edu>

* moving to production image size reduced to 178mb

Signed-off-by: Mohammed Abdi <mohammma@usc.edu>

* dynamically changing container port

Signed-off-by: Mohammed Abdi <mohammma@usc.edu>

* adding docker compose

Signed-off-by: Mohammed Abdi <mohammma@usc.edu>

---------

Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
mrsabath pushed a commit that referenced this pull request May 3, 2023
* break into two builds and reduce fe image to 781mb

Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local>

* moving to production image size reduced to 178mb

Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local>

* dynamically changing container port

Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>

* adding docker compose

Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>

---------

Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local>
Signed-off-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MacBook-Pro-2.local>
Co-authored-by: Mohammed Abdi <moabdi@Mohammeds-MBP-2.attlocal.net>
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants