Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling back to dev and SPIRE health check time automation #206

Merged
merged 2 commits into from
May 11, 2023

Conversation

mamy-CS
Copy link
Collaborator

@mamy-CS mamy-CS commented May 11, 2023

  • Temporarily rolling back to dev when running frontend on the container - this is because of the dynamic env variable update issue we have with react [Once the issue is resolved, we will ultimately move to production.
  • Instead of using an env variable for the spire health check frequency time, now we have a component that handles this through a drop-down.

Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
@mamy-CS mamy-CS added this to the 1.2.x milestone May 11, 2023
@mamy-CS mamy-CS requested a review from maia-iyer May 11, 2023 18:55
@mamy-CS mamy-CS requested a review from lumjjb as a code owner May 11, 2023 18:55
@mamy-CS mamy-CS self-assigned this May 11, 2023
@mamy-CS mamy-CS requested a review from mrsabath as a code owner May 11, 2023 18:55
Signed-off-by: Mohammed Abdi <mohammma@usc.edu>
Copy link
Collaborator

@mrsabath mrsabath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrsabath mrsabath merged commit 4744a09 into spiffe:v1.2.0 May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants