-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Makefile for Github #224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
mrsabath
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mrsabath
pushed a commit
that referenced
this pull request
May 26, 2023
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
maia-iyer
added a commit
that referenced
this pull request
Jun 1, 2023
* Removing backend + spire implementations Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Commented on Makefile and adjusted names Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Update .github/workflows/master-build.yaml Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> * Update Makefile Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> * Update Makefile Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> * Update Makefile Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> * Update Makefile Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> * Update Makefile Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> * Update Makefile Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> * Update Makefile Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> * Update Makefile Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> * rename variables Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * remove latest tag Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * New version v1.2.2 Signed-off-by: Mariusz Sabath <mrsabath@gmail.com> * Makefile nit Github (#224) Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Fixing Dockerfiles (#227) Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Added extra calls to authorization (#225) Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * adding local name Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * fixing build Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * additional commenting and renaming of local frontend build Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * adjust documentation Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * re-deleting files Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Makefile edits Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Comments Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Replacing DEV tag Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * nits Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Refactoring repo naming Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * adding dev-sha target Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Fix 'access denied' error when running in restricted (read-only) env Signed-off-by: Mariusz Sabath <mrsabath@gmail.com> * removing duplicate make targets Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * removing nit comment Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Update Makefile Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> * Update Makefile Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Co-authored-by: Mariusz Sabath <mrsabath@gmail.com> * Fix 'access denied' error when running in restricted (read-only) env Signed-off-by: Mariusz Sabath <mrsabath@gmail.com> * Fix startup error Signed-off-by: Mariusz Sabath <mrsabath@gmail.com> * Remove unneeded backend+SPIRE dockerfile Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> * Adding comment Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> --------- Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com> Signed-off-by: Mariusz Sabath <mrsabath@gmail.com> Co-authored-by: Maia Iyer <maia.raj.iyer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile uses $GITHUB_SHA if defined.