Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS/mTLS Documentation #251

Merged
merged 21 commits into from
Jun 13, 2023
Merged

Add TLS/mTLS Documentation #251

merged 21 commits into from
Jun 13, 2023

Conversation

maia-iyer
Copy link
Collaborator

No description provided.

@maia-iyer
Added TLS/mTLS Documentation
b36facf 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer maia-iyer added the documentation Improvements or additions to documentation label Jun 6, 2023
@maia-iyer maia-iyer self-assigned this Jun 6, 2023
@maia-iyer
removing extra files
1f54847 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer
make expandable sections
9589952 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer
adding collapsible
8bc303c 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer maia-iyer linked an issue Jun 6, 2023 that may be closed by this pull request
TLS/mTLS bugs and testing #131
Closed
mrsabath
mrsabath reviewed Jun 7, 2023
View reviewed changes
sample-keys/README.md Outdated Show resolved Hide resolved
sample-keys/README.md Outdated Show resolved Hide resolved
sample-keys/README.md Outdated Show resolved Hide resolved
sample-keys/README.md Outdated Show resolved Hide resolved
sample-keys/README.md Outdated Show resolved Hide resolved
maia-iyer and others added 4 commits June 8, 2023 12:00
@maia-iyer @mrsabath
Update sample-keys/README.md
65c51ad 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>
@maia-iyer @mrsabath
Update sample-keys/README.md
9a609cc 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>
@maia-iyer @mrsabath
Update sample-keys/README.md
520c98e 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>
@maia-iyer @mrsabath
Update sample-keys/README.md
d02b1d4 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>
@mrsabath mrsabath changed the title Added TLS/mTLS Documentation Add TLS/mTLS Documentation Jun 8, 2023
mrsabath
mrsabath reviewed Jun 9, 2023
View reviewed changes
sample-keys/README.md Outdated Show resolved Hide resolved
sample-keys/create-ca.sh Outdated Show resolved Hide resolved
sample-keys/create-ca.sh Outdated Show resolved Hide resolved
sample-keys/README.md Outdated Show resolved Hide resolved
mrsabath
mrsabath reviewed Jun 9, 2023
View reviewed changes
sample-keys/README.md Outdated Show resolved Hide resolved
@maia-iyer
Adjusted documentation
b773ae7 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer maia-iyer requested a review from mamy-CS as a code owner June 10, 2023 15:09
@maia-iyer
Edit create-ca file
90783f7 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer
Remove sample-keys from container
acf9b84 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer
restructure documentation
bc4a5bc 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer
added code
15e4d2b 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer
Modified scripts
9e26707 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer
edited readme
234a9ac 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
mrsabath
mrsabath reviewed Jun 13, 2023
View reviewed changes
examples/tls_mtls/README.md Outdated Show resolved Hide resolved
examples/tls_mtls/README.md Show resolved Hide resolved
examples/tls_mtls/README.md Show resolved Hide resolved
maia-iyer and others added 4 commits June 13, 2023 09:18
@maia-iyer
Remove sample keys from backend container
74fb39c 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer @mrsabath
Update examples/tls_mtls/README.md
4613705 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>
@maia-iyer
Fixing container file path
4adc396 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
@maia-iyer
Added note
0b72a6d 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>
mrsabath
mrsabath approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@mrsabath mrsabath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice PR providing a detailed information about TLS and mTLS setup. Thank you!
LGTM

examples/tls_mtls/README.md Outdated Show resolved Hide resolved
examples/tls_mtls/README.md Outdated Show resolved Hide resolved
maia-iyer and others added 2 commits June 13, 2023 12:09
@maia-iyer @mrsabath
Update examples/tls_mtls/README.md
52276a3 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>
@maia-iyer @mrsabath
Update examples/tls_mtls/README.md
b3b0479 
Signed-off-by: Maia Iyer <maia.raj.iyer@gmail.com>

Co-authored-by: Mariusz Sabath <mrsabath@gmail.com>
@maia-iyer maia-iyer merged commit dfac5f5 into v1.3 Jun 13, 2023
@maia-iyer maia-iyer deleted the tls_fix branch June 15, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsabath mrsabath mrsabath approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb lumjjb is a code owner

@mamy-CS mamy-CS Awaiting requested review from mamy-CS mamy-CS is a code owner

Assignees

@maia-iyer maia-iyer

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TLS/mTLS bugs and testing
2 participants
@maia-iyer @mrsabath