fix(kubernetes): Fix daemonset stability condition (#3863) #3865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we'll consider a daemonset stable if it has the correct number of replicas, even if they are of the wrong generation. Fix this by adding a check for the generation, just as we do for replica sets. Also, fix a bug in the replica set implementation where we are comparing Integers using == instead of using .equals.
ezimanyi
approved these changes
Jul 11, 2019
ezimanyi
deleted the
auto-cherry-pick-1.15-5c5939c77a596e0b85fb42604104e8f3b9eef989
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we'll consider a daemonset stable if it has the correct
number of replicas, even if they are of the wrong generation. Fix
this by adding a check for the generation, just as we do for replica
sets.
Also, fix a bug in the replica set implementation where we are
comparing Integers using == instead of using .equals.