-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dockerfile): use deterministic version for kubectl #4064
Conversation
reading from `stable.txt` causes builds to be non-deterministic which could lead to problems in the future. we should be explicit about the version of `kubectl` that we ship. `v1.16.0` was the latest version as of this PR.
I wonder if we might want to actually stay one release behind the latest, given that So if we ship |
So, I went with 1.16.0 because that's what got shipped with the 1.16 and 1.15 releases yesterday (10/1/2019). I'm hesitant to go backwards after that, honestly. How do you feel about shipping multiple versions of |
Given that all the calls to It's true that we probably don't want to go backwards, but maybe going forward we can think more about the policy, and pin |
The |
@spinnakerbot cherry-pick 1.16 |
@spinnakerbot cherry-pick 1.15 |
reading from `stable.txt` causes builds to be non-deterministic which could lead to problems in the future. we should be explicit about the version of `kubectl` that we ship. `v1.16.0` was the latest version as of this PR.
Cherry pick successful: #4065 |
reading from `stable.txt` causes builds to be non-deterministic which could lead to problems in the future. we should be explicit about the version of `kubectl` that we ship. `v1.16.0` was the latest version as of this PR.
Cherry pick successful: #4066 |
Oh, nice, didn't realize you could configure |
reading from `stable.txt` causes builds to be non-deterministic which could lead to problems in the future. we should be explicit about the version of `kubectl` that we ship. `v1.16.0` was the latest version as of this PR.
reading from `stable.txt` causes builds to be non-deterministic which could lead to problems in the future. we should be explicit about the version of `kubectl` that we ship. `v1.16.0` was the latest version as of this PR.
reading from
stable.txt
causes builds to be non-deterministic which could lead to problems in the future. we should be explicit about the version ofkubectl
that we ship.v1.16.0
was the latest version as of this PR.