fix(config): adding some missing instances block device config #4087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abelzberg please let me know if you have feedback |
marchello2000
force-pushed
the
mark/block_device_defaults
branch
from
30e93f0
to
db5be7d
Compare
|
Added offline feedback from @abelzberg |
cfieber
requested changes
Oct 14, 2019
| @@ -99,6 +99,11 @@ class BlockDeviceConfig { | |||
| "i3.16xlarge" : enumeratedBlockDevicesWithVirtualName(8), | |||
| "i3.metal" : enumeratedBlockDevicesWithVirtualName(8), | |||
|
|
|||
| "i3en.large" : enumeratedBlockDevicesWithVirtualName(1), | |||
| "i3en.xlarge" : enumeratedBlockDevicesWithVirtualName(1), | |||
| "i3en.2xlarge": enumeratedBlockDevicesWithVirtualName(1), | |||
There was a problem hiding this comment.
Suggested change
| "i3en.2xlarge": enumeratedBlockDevicesWithVirtualName(1), | |
| "i3en.2xlarge": enumeratedBlockDevicesWithVirtualName(2), |
There was a problem hiding this comment.
I think, based on this table: https://aws.amazon.com/ec2/instance-types/i3en/
There was a problem hiding this comment.
worth adding the rest of the i3en types from that page while you are in here?
| "m5d.12xlarge" : enumeratedBlockDevicesWithVirtualName(2), | ||
| "m5d.16xlarge" : enumeratedBlockDevicesWithVirtualName(2), |
There was a problem hiding this comment.
Suggested change
| "m5d.16xlarge" : enumeratedBlockDevicesWithVirtualName(2), | |
| "m5d.16xlarge" : enumeratedBlockDevicesWithVirtualName(4), |
| "r5d.12xlarge" : enumeratedBlockDevicesWithVirtualName(2), | ||
| "r5d.16xlarge" : enumeratedBlockDevicesWithVirtualName(2), |
There was a problem hiding this comment.
Suggested change
| "r5d.16xlarge" : enumeratedBlockDevicesWithVirtualName(2), | |
| "r5d.16xlarge" : enumeratedBlockDevicesWithVirtualName(4), |
| "m5.12xlarge" : sizedBlockDevicesForEbs(120), | ||
| "m5.16xlarge" : sizedBlockDevicesForEbs(120), | ||
| "m5.24xlarge" : sizedBlockDevicesForEbs(120), | ||
|
|
||
| "m5d.large" : enumeratedBlockDevicesWithVirtualName(1), | ||
| "m5d.xlarge" : enumeratedBlockDevicesWithVirtualName(1), | ||
| "m5d.2xlarge" : enumeratedBlockDevicesWithVirtualName(1), | ||
| "m5d.4xlarge" : enumeratedBlockDevicesWithVirtualName(1), |
There was a problem hiding this comment.
Suggested change
| "m5d.4xlarge" : enumeratedBlockDevicesWithVirtualName(1), | |
| "m5d.4xlarge" : enumeratedBlockDevicesWithVirtualName(2), |
cfieber
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.