fix(titus): Adjust retries on upsert scaling policy operation #4090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeyrschabu
commented
Oct 15, 2019
•
jeyrschabu
commented
- wrap a retry on scaling policy create call for good measure
- fix retry count/timeout for checking if the scaling policy was applied
- make retry to be exponential
|
When creating a new scaling policy, Spinnaker polls titus for approximately 50s to check if the policy was applied. |
robzienert
reviewed
Oct 15, 2019
| } | ||
| }, 5000, 10, false) |
- wrap a retry on scaling policy create call for good measure - fix retry count/timeout for if checking scaling policy was applied - make retry to be exponential
jeyrschabu
force-pushed
the
titus-upsert-policy
branch
from
a382e44
to
66b9d84
Compare
cfieber
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.