Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): upgrade kork #4124

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Conversation

plumpy
Copy link
Member

@plumpy plumpy commented Oct 25, 2019

I don't know why we I was using these deprecated (and now deleted)
classes in the tests; we don't use them in the actual stateful disk
code. (The test is just making sure we copy statefulPolicy over, so
doesn't really care what is in it.)

I don't know why we I was using these deprecated (and now deleted)
classes in the tests; we don't use them in the actual stateful disk
code. (The test is just making sure we copy statefulPolicy over, so
doesn't really care what is in it.)
Copy link
Contributor

@maggieneterval maggieneterval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇺🇸 💾 ⬆️ 🎉

@plumpy plumpy added the ready to merge Approved and ready for a merge label Oct 25, 2019
@plumpy plumpy merged commit fa202f1 into spinnaker:master Oct 25, 2019
@plumpy plumpy deleted the upgrade_kork branch October 25, 2019 19:11
@mergify mergify bot added the auto merged Merged automatically by a bot label Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants