fix(aws/cache): index authoritative clusters by application #4632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an application attribute to authoritative clusters so that the lookup by application succeeds. Also includes relationships from the cluster to the server groups we are crawling
cfieber
commented
May 29, 2020
| Map<String, Object> cacheAttributes = new HashMap<>(); | ||
| cacheAttributes.put("name", clusterAttributes.get(clusterNameAttribute)); | ||
| cacheAttributes.put( | ||
| "application", clusterAttributes.get(clusterApplicationAttribute)); |
There was a problem hiding this comment.
this specifically was necessary because we use the getAllByApplication lookup to find the cluster objects
cfieber
commented
May 29, 2020
| Map<String, String> clusterKey = Keys.parse(clusterData.id) | ||
|
|
||
| if (clusterKey == null) { |
There was a problem hiding this comment.
now titus clusters are also indexed by application and end up in the results. The key parser returns null for a key from a different provider so we'll filter them out in here
(the same wasn't necessary in TitusClusterProvider because it doesn't use getAllByApplication - though maybe it should...)
cfieber
added a commit
to cfieber/clouddriver
that referenced
this pull request
Jun 11, 2020
…pinnaker#4632)" This reverts commit 64a9b46.
cfieber
added a commit
that referenced
this pull request
Jun 11, 2020
This has turned out to have a bunch of sneaky side-effects because of the way the cluster relationships are built up, and didn't end up fixing the issue I had hoped it would when you delete the last server group in a region so for now I'm going to just back it out and will revisit it in the future. * Revert "fix(aws/cache): include informative results in CatsClusterCachingAgent (#4668)" This reverts commit b562da8. * Revert "fix(aws/cache): index authoritative clusters by application (#4632)" This reverts commit 64a9b46. * Revert "fix(cache): adds a proper authoritative clusters source for aws/titus (#4615)" This reverts commit 467ad58.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an application attribute to authoritative clusters so that the lookup by application succeeds.
Also includes relationships from the cluster to the server groups we are crawling