fix(titus/build): use version 1.37.1 of io.grpc.* to fix compiler errors (#5487) #5517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors (spinnaker#5487) * chore(dependencies): Autobump korkVersion * fix(titus/build): use version 1.37.1 of io.grpc.* to fix compiler errors > Task :clouddriver-titus:compileJava FAILED /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/LoadBalancerServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/JobManagementServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/EvictionServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/SupervisorServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/TaskRelocationServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/AutoScalingServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/v4/ResourceConsumptionServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/v4/ResourceAllocationServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/v4/ResourceAllocationArchiveServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/v4/TaskManagementServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/v4/MachineServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/v4/TaskManagementArchiveServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/AgentManagementServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/ClusterMembershipServiceGrpc.java:14: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/SchedulerServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/grpc/protogen/HealthGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/UserIPServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations /home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/grpc/com/netflix/titus/ValidatorIPServiceGrpc.java:10: error: cannot find symbol @io.grpc.stub.annotations.GrpcGenerated ^ symbol: class GrpcGenerated location: package io.grpc.stub.annotations 18 errors Note that before this PR, gradle used version 1.27.2 of io.grpc.*: $ ./gradlew :clouddriver-titus:dI --dependency io.grpc:grpc-stub > Task :clouddriver-titus:dependencyInsight io.grpc:grpc-stub:1.27.2 (by constraint) variant "compile" [ org.gradle.status = release (not requested) org.gradle.usage = java-api org.gradle.libraryelements = jar (compatible with: classes+resources) org.gradle.category = library Requested attributes not found in the selected variant: org.gradle.dependency.bundling = external org.jetbrains.kotlin.platform.type = jvm org.gradle.jvm.version = 11 ] io.grpc:grpc-stub:1.27.2 \--- io.spinnaker.kork:kork-bom:7.116.0 \--- compileClasspath io.grpc:grpc-stub:[1.10.0,) -> 1.27.2 \--- compileClasspath I haven't been able to find a place in kork that specifies anything for io.grpc, nor where 1.27.2 comes from. I chose version 1.37.1 because it's the newest version that works, yet sticks with guava 30.0-jre. Anything newer and we end up with 30.1-android. Now we have: $ ./gradlew :clouddriver-titus:dI --dependency io.grpc:grpc-stub > Task :clouddriver-titus:dependencyInsight io.grpc:grpc-stub:1.37.1 variant "compile" [ org.gradle.status = release (not requested) org.gradle.usage = java-api org.gradle.libraryelements = jar (compatible with: classes+resources) org.gradle.category = library Requested attributes not found in the selected variant: org.gradle.dependency.bundling = external org.jetbrains.kotlin.platform.type = jvm org.gradle.jvm.version = 11 ] Selection reasons: - By constraint - By conflict resolution : between versions 1.37.1 and 1.27.2 io.grpc:grpc-stub:1.37.1 \--- compileClasspath io.grpc:grpc-stub:1.27.2 -> 1.37.1 \--- io.spinnaker.kork:kork-bom:7.116.0 \--- compileClasspath Co-authored-by: root <root@11084802b712> (cherry picked from commit 71f8f0d) # Conflicts: # gradle.properties
link108
requested review from
ajordens,
aravindmd and
jeyrschabu
as code owners
dogonthehorizon
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix in favor of #5514. The guava version being pulled in was causing issues.