Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws/test): Fix requests for time in "where" not fixed #6089

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix(aws/test): Fix requests for time in "where" not fixed #6089

merged 1 commit into from
Nov 10, 2023

Conversation

E-Paine
Copy link
Contributor

@E-Paine E-Paine commented Nov 10, 2023

Previously, calls to AsgConfigHelper.createDefaultSuffix() in the AsgConfigHelperSpec test "should return name correctly" used the actual local time, since the setup function runs after a where block. This would very occasionally result in a test failure.

This PR resolves the issue by using setupSpec instead (correspondingly changing cleanup to cleanupSpec).

@dbyron-sf
Copy link
Contributor

Thanks for this change @E-Paine ! The test prefix is for commits that add test coverage. In this case, I think fix(aws/test) is more correct. Would you mind adjusting the commit message and PR description?

@dbyron-sf dbyron-sf changed the title test(aws): Fix requests for time in "where" not fixed fix(aws/test): Fix requests for time in "where" not fixed Nov 10, 2023
@dbyron-sf
Copy link
Contributor

I took care of it. Thanks again @E-Paine !

@dbyron-sf dbyron-sf added the ready to merge Approved and ready for a merge label Nov 10, 2023
@mergify mergify bot added the auto merged Merged automatically by a bot label Nov 10, 2023
@mergify mergify bot merged commit 015c948 into spinnaker:master Nov 10, 2023
16 checks passed
@E-Paine E-Paine deleted the aws-time-test branch November 14, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

@jeyrschabu jeyrschabu Awaiting requested review from jeyrschabu jeyrschabu is a code owner

@ajordens ajordens Awaiting requested review from ajordens ajordens is a code owner

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.33
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@E-Paine @dbyron-sf @spinnakerbot