fix(config): Fix typings for SpinnakerSettings (#7556)

- add pubsub in notifications - add disableManualOidcDialog in amazon loadBalancers
spinnaker · Oct 24, 2019 · 230ffb5 · 230ffb5
1 parent 727300d
commit 230ffb5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 20 deletions.
diff --git a/app/scripts/modules/amazon/src/aws.settings.ts b/app/scripts/modules/amazon/src/aws.settings.ts
@@ -15,8 +15,9 @@ export interface IAWSProviderSettings extends IProviderSettings {
   };
   defaultSecurityGroups?: string[];
   loadBalancers?: {
-    inferInternalFlagFromSubnet: boolean;
     certificateTypes?: string[];
+    disableManualOidcDialog?: boolean;
+    inferInternalFlagFromSubnet: boolean;
   };
   useAmiBlockDeviceMappings?: boolean;
   classicLaunchLockout?: number;

diff --git a/app/scripts/modules/core/src/config/settings.ts b/app/scripts/modules/core/src/config/settings.ts
@@ -7,30 +7,19 @@ export interface IAdditionalHelpLinks {
 }
 
 export interface IProviderSettings {
+  bakeryRegions?: string[];
   defaults: any;
   resetToOriginal?: () => void;
 }
 
 export interface INotificationSettings {
-  email: {
-    enabled: boolean;
-  };
-  bearychat: {
-    enabled: boolean;
-  };
-  googlechat: {
-    enabled: boolean;
-  };
-  sms: {
-    enabled: boolean;
-  };
-  slack: {
-    botName: string;
-    enabled: boolean;
-  };
-  githubStatus: {
-    enabled: boolean;
-  };
+  bearychat: { enabled: boolean };
+  email: { enabled: boolean };
+  githubStatus: { enabled: boolean };
+  googlechat: { enabled: boolean };
+  pubsub: { enabled: boolean };
+  slack: { botName: string; enabled: boolean };
+  sms: { enabled: boolean };
 }
 
 export interface IFeatures {