Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(taskView): Implement opt-in paginated request for TaskView (backport #10093) #10094

Merged
merged 4 commits into from
May 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 7, 2024

The taskView by default tries to load the full task list (as allowed by the Orca api configuration). However for applications that are heavily used and have a high number of tasks retrieving the full task list in a single request is resulting many times in timeout either because of the backend or because the Deck timeout was reached.

The task controller on the backend supports pagination so this PR attempts to provide the end user control on the max task limit per page to be retrieved from the backend.
The datasource logic doesnt change in the PR - Deck will still consider the taskView as loaded when all the tasks are retrieved but what changes is that by adding the opt-in setting in settings-local.js

SETTINGS.tasksViewLimitPerPage = number; 

on the taskView the single request will be splitted in multiple requests with limit=&page=.

screenRecording.mov

This is an automatic backport of pull request #10093 done by [Mergify](https://mergify.com).

* feat(tasksview): Allowing opt-in pagination for tasks view loading

* feat(taskView): Implement opt-in paginated request for TaskView

(cherry picked from commit 5fa1e96)

# Conflicts:
#	yarn.lock
Copy link
Contributor Author

mergify bot commented May 7, 2024

Cherry-pick of 5fa1e96 has failed:

On branch mergify/bp/release-1.32.x/pr-10093
Your branch is up to date with 'origin/release-1.32.x'.

You are currently cherry-picking commit 5fa1e96b90.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   packages/core/src/config/settings.ts
	modified:   packages/core/src/task/task.dataSource.js
	modified:   packages/core/src/task/task.read.service.ts

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   yarn.lock

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@spinnakerbot
Copy link
Contributor

Features cannot be merged into release branches. The following commits are not tagged as one of "fix, chore, docs, perf, test":

Read more about commit conventions and patch releases here.

christosarvanitis and others added 3 commits May 7, 2024 17:34
…) (#10098)

* feat(tasksview): Allowing opt-in pagination for tasks view loading

* feat(taskView): Implement opt-in paginated request for TaskView

(cherry picked from commit 5fa1e96)
* feat(taskView): Implement opt-in paginated request for TaskView (#10093)

* feat(tasksview): Allowing opt-in pagination for tasks view loading

* feat(taskView): Implement opt-in paginated request for TaskView

(cherry picked from commit 5fa1e96)

* fix(tasksView): Resolving conflicts on yarn.lock backport
@jasonmcintosh jasonmcintosh added the ready to merge Reviewed and ready for merge label May 9, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label May 9, 2024
@mergify mergify bot merged commit 7d8ba66 into release-1.32.x May 9, 2024
4 checks passed
@mergify mergify bot deleted the mergify/bp/release-1.32.x/pr-10093 branch May 9, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot conflicts ready to merge Reviewed and ready for merge target-release/1.32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants