feat(google): Add support for accelerators when deploying VMs #6467

ghost · 2019-02-01T18:49:15Z

User can add GPU to VMs in GCE server group modals
The set of GPUs available varies by zone
The maximum number of GPUs per instance varies by card
Adds a functional test to verify that the GPU type list renders as expected

Here's how the component looks in the server group modal:

After deployment via Spinnaker, here's the instance with the attached accelerator:

GIF of functional test run:

maggieneterval

awesome!

jtk54 · 2019-02-04T15:04:59Z

Retroactive LGTM. In the future I'd split up the feature work and functional tests into two separate commits on the same PR so it's easier to review. Looks great otherwise.

* chore(kubernetes): Bump version to 0.0.21 27d8a12 chore(eslint): Fix lint errors a8c1749 chore(package): Just Update Prettier™ 9eccc0f refactor(artifacts): Generalize artifact delegate for reuse (#6495) 6c54b61 fix(kubernetes): do not override `location` and `replicas` in new Scale Manifest stage a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 54157f2 fix(kubernetes/serverGroup): Remove module.exports assignment in typescript file 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages d53836b refactor(kubernetes/modal): Refactor kubernetes modals to use WizardPage component dba26d8 feat(kubernetes/v2): Converts CopyToClipboard to React Component (#6451) 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 65c2601 fix(kubernetes): post strategic patch body as object 51a8542 fix(kubernetes): fix account selection by handling null values passed to ManifestSelector.isExpression 35be1f0 refactor(*): Don't use js or ts file extension in require() a02a5e1 chore(k8s): clean up imports (#6430) fa18bdc feat(kubernetes/v2): Adds CopyToClipboard component to ease getting text from UI (#6419) 98a85e9 chore(*): bump @types/enzyme@3.1.15, @types/jasmine@3.3.7, enzyme@3.8.0, enzyme-adapter-react-16@1.7.1, karma@4.0.0, karma-jasmine@2.0.1, karma-webpack@3.0.5, typescript@^3.2.4, jasmine-core@3.3.0 - disable jasmine 3.0's random test order by default feature 93f1209 fix(appengine/google/kubernetes): change logo background colors to official brand colors (#6347) e802c45 fix(*): allow modal to stay open on auto-close (#6329) 6fee54d fix(kubernetes): specify monospace fonts to prevent cursor misalignment in ace editor 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) * chore(google): Bump version to 0.0.5 a8c1749 chore(package): Just Update Prettier™ a35088a chore(webpack): Switch to TerserPlugin. Split bundles into ~5mb chunks 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages d09a910 feat(google): Add support for accelerators when deploying VMs (#6467) 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 35be1f0 refactor(*): Don't use js or ts file extension in require() 87013c6 config(google): Update GCE's base URL to the new domain (#6401) 9f90ebd fix(google): safe healthcheck lookups when cloning server group b920442 fix(google): differentiate among autohealing health check kinds 786862b fix(google): fix autohealing clone logic 93f1209 fix(appengine/google/kubernetes): change logo background colors to official brand colors (#6347) e802c45 fix(*): allow modal to stay open on auto-close (#6329) d4127fa fix(google): prevent parent server group from overwriting null clone autohealing policies 86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280) 3afbd00 fix(bake): Allow null extended attributes in bake stages (#6256) 6b8188b chore(*): Add core alias to module tsconfigs

hari-mopuri · 2019-02-20T13:16:40Z

In which deck version this feature is available?
if it is not available when it will be released ?

rampatnaik · 2019-02-20T13:39:15Z

Yes please merge to release version.

jtk54 · 2019-02-20T13:42:06Z

This will land in Spinnaker 1.13.x.

rampatnaik · 2019-02-20T13:48:30Z

Can we cherry pick to 1.12.x version or 1.11.x ?? , is it possible..

Our migration is waiting for this fix

jtk54 · 2019-02-20T14:49:15Z

Generally our policy is not to cherry pick features (like this) into prior releases to promote stability of the releases.

rampatnaik · 2019-02-23T12:28:50Z

I am using 1.12.x our project need this fix.
Is there other way too apply this feature?

maggieneterval · 2019-02-25T16:37:09Z

Hey @rampatnaik, although we would recommend waiting for 1.13, you may follow these instructions to run the unvalidated nightly build of Spinnaker: https://www.spinnaker.io/community/contributing/releasing/#run-the-nightly-builds-not-recommended

anup13kumar · 2019-03-26T06:41:08Z

@maggieneterval ,
We can see 1.13 released and we've upgraded our spinnkaer to same version but we can see accelerator option in deploy config but its not enabled
Could you please update adding GPU feature is released in this version ? If Yes do we need to change any configuration from our end.

Thanks,
AK

ciciya-lal · 2019-03-26T12:01:35Z

@sbwsg ,

after upgarding spinnaker 1.13 release, we can see that gpu accelerate is showing only for us-central-1 region.
Our application is hosted in these to zones asia-east- and us-east-1 .Can you please fix this issue?

Also we have observed one more issue..

After selecting any other region and then trying gpu accelerate option with us-central-1 ia not listing gpu accelerate option.
No action observed while selecting gpu accelerate.

Thanks,Cici

ghost · 2019-03-26T12:38:22Z

@anup13kumar @ciciya-lal

Which zones (accelerators vary in support per zone) have you tried? The list of zones where accelerators are supported is available here: https://cloud.google.com/compute/docs/gpus/#gpus-list
Are you attempting to configure a multi-zone deployment? Accelerator support in Spinnaker is currently limited to single zones.

anup13kumar · 2019-03-26T12:50:13Z

@sbwsg
Thanks for the update now its working fine i have changed zone and able to attach GPU

ciciya-lal · 2019-04-01T10:44:36Z

@sbwsg ,

As per the url : [https://cloud.google.com/compute/docs/gpus/#gpus-list] , GPU accelerate will support for multiple zones..

for example:
NVIDIA® Tesla® K80 : us-east1-c , us-east1-d

But spinnaker allows us to add GPU only in one supporting zone.

Our Requirement:

instance should able to map multiple supporting zones us-east1-c , us-east1-d and aceelerate should enable for supporting multiple zones.

Can you please help ?

Thanks,Cici

ghost · 2019-04-01T12:17:15Z

@ciciya-lal Indeed, we were aware of this when we implemented the feature and decided to only support single zones for simplicity in the first iteration.

Adding multi-zone support will be considered a new enhancement. Please create a github issue at https://github.com/spinnaker/spinnaker/issues/new and tag me on it. Thank you!

ciciya-lal · 2019-04-02T03:20:42Z

@sbwsg , Thanks for supporting us for all fixes..
New issue raised : https://github.com/spinnaker/spinnaker/issues/4228 .
Please check..

Thanks ,ciciya

ghost requested review from ezimanyi, jtk54 and maggieneterval February 1, 2019 18:49

feat(google): Add support for accelerators when deploying VMs

3dcf224

maggieneterval approved these changes Feb 1, 2019

View reviewed changes

ghost merged commit d09a910 into spinnaker:master Feb 1, 2019

ghost deleted the gce-accelerators branch February 1, 2019 20:27

spinnakerbot added the target-release/1.13 label Feb 1, 2019

anotherchrisberry mentioned this pull request Feb 13, 2019

Bump package kubernetes to 0.0.21 and google to 0.0.5 #6540

Merged

ghost mentioned this pull request Mar 26, 2019

fix(google): add better help text around accelerators #6750

Merged

maggieneterval mentioned this pull request Aug 26, 2019

Support for GPUs in distributed multiple zones deployments spinnaker/spinnaker#4796

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(google): Add support for accelerators when deploying VMs #6467

feat(google): Add support for accelerators when deploying VMs #6467

ghost commented Feb 1, 2019

maggieneterval left a comment

jtk54 commented Feb 4, 2019

hari-mopuri commented Feb 20, 2019 •

edited

Loading

rampatnaik commented Feb 20, 2019

jtk54 commented Feb 20, 2019

rampatnaik commented Feb 20, 2019

jtk54 commented Feb 20, 2019

rampatnaik commented Feb 23, 2019

maggieneterval commented Feb 25, 2019

anup13kumar commented Mar 26, 2019

ciciya-lal commented Mar 26, 2019

ghost commented Mar 26, 2019

anup13kumar commented Mar 26, 2019

ciciya-lal commented Apr 1, 2019 •

edited

Loading

ghost commented Apr 1, 2019

ciciya-lal commented Apr 2, 2019

feat(google): Add support for accelerators when deploying VMs #6467

feat(google): Add support for accelerators when deploying VMs #6467

Conversation

ghost commented Feb 1, 2019

Here's how the component looks in the server group modal:

After deployment via Spinnaker, here's the instance with the attached accelerator:

GIF of functional test run:

maggieneterval left a comment

Choose a reason for hiding this comment

jtk54 commented Feb 4, 2019

hari-mopuri commented Feb 20, 2019 • edited Loading

rampatnaik commented Feb 20, 2019

jtk54 commented Feb 20, 2019

rampatnaik commented Feb 20, 2019

jtk54 commented Feb 20, 2019

rampatnaik commented Feb 23, 2019

maggieneterval commented Feb 25, 2019

anup13kumar commented Mar 26, 2019

ciciya-lal commented Mar 26, 2019

ghost commented Mar 26, 2019

anup13kumar commented Mar 26, 2019

ciciya-lal commented Apr 1, 2019 • edited Loading

ghost commented Apr 1, 2019

ciciya-lal commented Apr 2, 2019

hari-mopuri commented Feb 20, 2019 •

edited

Loading

ciciya-lal commented Apr 1, 2019 •

edited

Loading