refactor(core): Convert most triggers from angular to react

[Jammy-Louie]

• all triggers but CRON have been converted
• triggers which have already been converted to react have been unified

spinnaker/spinnaker#4295

[Jammy-Louie]

@spinnakerbot add-label angular2react

[Jammy-Louie]

@christopherthielen Pretty big refactor on the individual triggers. Cron is going to require a little more time due to the fact it made use of an external angular library

[christopherthielen]

Great work, this is awesome!
One thing I'd like to avoid is using component inheritance when possible. React docs recommend against this and suggest using composition instead https://reactjs.org/docs/composition-vs-inheritance.html

For example, in BaseBuildTriggerTemplate, instead of using an abstract method getBuildTriggerType(), you can add a triggerType prop to the component and then pass that prop in from the more specific component, e.g:

const JenkinsTriggerTemplate = () => <BaseBuildTriggerTemplate triggerType={BuildServiceType.Jenkins} />

(side note: then the component could be renamed to BuildTriggerTemplate as well)

In the case of something more complex such as BaseBuildTrigger which is loading data, etc in the parent class, you can use a render prop to pass data to a child in an unopinionated way.

That noted, I'm OK with merging this as-is and refactoring later, if it makes sense to invest in that.

[Jammy-Louie]

@christopherthielen I've made the changes to use composition as you suggested. If everything looks okay I'll merge.

Thanks!

[christopherthielen]

Love it, thanks for making those changes!!