fix(*): Fix imports #6991
Merged
fix(*): Fix imports #6991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deck build is currently failing as non-allowed imports are present; fix these to import submodules
|
Fixes issue from #6970. It looks like we don't run the full build when testing a PR, so that's why travis passed on the PR but our build process is failing. |
christopherthielen
approved these changes
May 14, 2019
|
It looks like we skip for performance reasons: Line 5 in ea23876 though maybe it makes sense to re-enable the full build to avoid only catching things after they get merged? |
|
Weird, the travis PR build actually did fail. |
|
oh, got it! This was the |
|
Yeah, it passed on the PR itself (though did output a warning about this somewhere deep in the hundreds of lines of output) |
anotherchrisberry
added a commit
that referenced
this pull request
May 15, 2019
* chore(core): Bump version to 0.0.365 0fc8946 fix(core): request project pipeline configs just in time (#6980) cfd7690 fix(core): include un-run pipelines when filtering by text (#6979) 10fbec5 fix(core): set graph label node height correctly (#6993) 0ed0ab6 fix(artifacts): Fix fetching helm artifact versions (#6995) dfc84b1 refactor(core): add React Components for PageSection and PageNavigator (#6926) ce8a163 fix(cf): add Artifactory link (#6994) f7cb7ab chore(core): remove hipchat notification module (#6884) 98c9327 fix(*): Fix imports (#6991) c8590ff refactor(core): Convert most triggers from angular to react * chore(docker): Bump version to 0.0.39 c8590ff refactor(core): Convert most triggers from angular to react
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deck build is currently failing as non-allowed imports are present; fix these to import submodules