Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): request project pipeline configs just in time #6980

Merged
merged 3 commits into from
May 15, 2019
Merged

fix(core): request project pipeline configs just in time #6980

merged 3 commits into from
May 15, 2019

Conversation

maggieneterval
Copy link
Contributor

Closes spinnaker/spinnaker#4359

  • Before: on project configuration modal open, request pipelineConfigs for every application associated with the project.
  • After: on project configuration modal open, request pipelineConfigs for only those applications associated with a given project's pipelines. Request additional applications' pipelineConfigs just in time if they are selected in the Pipelines section.

christopherthielen
christopherthielen approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@christopherthielen christopherthielen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I don't understand how this fixes the 500 errors, but I trust your judgement!

@maggieneterval
Copy link
Contributor Author

@christopherthielen since the 500s seem to only be reproducible when hammering front50 with many simultaneous /pipelineConfig requests, my hope is that hammering it with only the minimum number of requests necessary at any point will at least make it much harder to run into this issue 🤷‍♀️

@maggieneterval
Copy link
Contributor Author

(though if you have project pipelines already setup for every application associated with your project, this will make no difference)

@anotherchrisberry anotherchrisberry merged commit 0fc8946 into spinnaker:master May 15, 2019
@maggieneterval
Copy link
Contributor Author

@spinnakerbot cherry-pick 1.12

@spinnakerbot
Copy link
Contributor

Cherry pick failed: Command failed (cherry pick commit 0fc8946) with exit code 1:

error: could not apply 0fc8946ac... fix(core): request project pipeline configs just in time (#6980)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

@anotherchrisberry anotherchrisberry mentioned this pull request May 15, 2019
Merged
anotherchrisberry added a commit that referenced this pull request May 15, 2019
@anotherchrisberry
Bump package core to 0.0.365 and docker to 0.0.39 (#6997)
52c637b 
* chore(core): Bump version to 0.0.365

0fc8946 fix(core): request project pipeline configs just in time (#6980)
cfd7690 fix(core): include un-run pipelines when filtering by text (#6979)
10fbec5 fix(core): set graph label node height correctly (#6993)
0ed0ab6 fix(artifacts): Fix fetching helm artifact versions (#6995)
dfc84b1 refactor(core): add React Components for PageSection and PageNavigator (#6926)
ce8a163 fix(cf): add Artifactory link (#6994)
f7cb7ab chore(core): remove hipchat notification module (#6884)
98c9327 fix(*): Fix imports (#6991)
c8590ff refactor(core): Convert most triggers from angular to react

* chore(docker): Bump version to 0.0.39

c8590ff refactor(core): Convert most triggers from angular to react
@maggieneterval
Copy link
Contributor Author

@spinnakerbot cherry-pick 1.13

@maggieneterval
Copy link
Contributor Author

@spinnakerbot cherry-pick 1.14

spinnakerbot pushed a commit that referenced this pull request May 15, 2019
@maggieneterval
fix(core): request project pipeline configs just in time (#6980)
ee65297
@spinnakerbot
Copy link
Contributor

Cherry pick successful: #7005

spinnakerbot pushed a commit that referenced this pull request May 15, 2019
@maggieneterval
fix(core): request project pipeline configs just in time (#6980)
864ebbc
@spinnakerbot
Copy link
Contributor

Cherry pick successful: #7006

maggieneterval pushed a commit that referenced this pull request May 15, 2019
@spinnakerbot @maggieneterval
fix(core): request project pipeline configs just in time (#6980) (#7005)
b933bcf
maggieneterval pushed a commit that referenced this pull request May 15, 2019
@spinnakerbot @maggieneterval
fix(core): request project pipeline configs just in time (#6980) (#7006)
7dbd005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherthielen christopherthielen christopherthielen approved these changes

Assignees
No one assigned
Labels
target-release/1.15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pipelineConfigs return 500 via deck, 200 via curl
4 participants
@maggieneterval @spinnakerbot @christopherthielen @anotherchrisberry