-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(stages): Fixed alias matching, added fallback and unit tests #7080
Conversation
Does this buy us anything over using |
I was thinking this would have absolutely 0 dependency on anything in orca, but let me take a look and play with |
Turns out I ended up only having to refactor
This is basically what the new unit test Finally, also added the ability to gracefully degrade back to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
939d608 fix(pipeline): fix invisible parameter when default is not in options (spinnaker#7125) 5c4facb fix(core/pipeline): stop searching stage context, being greedy about parentExecutions (spinnaker#7127) 8fe74bc fix(core): do not inject default execution window values on render (spinnaker#7122) ee6fbe0 fix(core/pipeline): use correct visibility default for stage durations (spinnaker#7121) c88234c refactor(stages): Fixed alias matching, added fallback and unit tests (spinnaker#7080) c358801 refactor(core): Reactify ExecutionWindows component (spinnaker#7113) 744123d fix(artifact): use artifact icons in server group link (spinnaker#7118) b8aebd7 fix(forms): Fixed SpelText not firing onChange upon autocomplete (spinnaker#7114) 4e2f749 refactor(core): reactify overrideFailure component (spinnaker#7107) 4f07aeb fix(core): Make template table list scrollable (spinnaker#7111) e5d6115 fix(core): Display template inherited items (mptv2) as read only (spinnaker#7102)
939d608 fix(pipeline): fix invisible parameter when default is not in options (#7125) 5c4facb fix(core/pipeline): stop searching stage context, being greedy about parentExecutions (#7127) 8fe74bc fix(core): do not inject default execution window values on render (#7122) ee6fbe0 fix(core/pipeline): use correct visibility default for stage durations (#7121) c88234c refactor(stages): Fixed alias matching, added fallback and unit tests (#7080) c358801 refactor(core): Reactify ExecutionWindows component (#7113) 744123d fix(artifact): use artifact icons in server group link (#7118) b8aebd7 fix(forms): Fixed SpelText not firing onChange upon autocomplete (#7114) 4e2f749 refactor(core): reactify overrideFailure component (#7107) 4f07aeb fix(core): Make template table list scrollable (#7111) e5d6115 fix(core): Display template inherited items (mptv2) as read only (#7102)
Experimental: This would allow multiple implementations of a single stage type. Similar to how a specific
type
can beprovided
by multiple cloud providers, but in this case we use a genericaltKey
instead ofcloudProvider
for matching.