fix(core): Display template inherited items (mptv2) as read only #7102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisjimenez
force-pushed
the
louis/mark-inherited
branch
from
a2ccab7
to
a54d707
Compare
louisjimenez
commented
Jun 11, 2019
| <div className="checkbox"> | ||
| <label> | ||
| <input type="checkbox" checked={required} onChange={handleRequiredChange} /> | ||
| <fieldset disabled={inherited} className={classNames({ 'templated-pipeline-item': inherited })}> |
There was a problem hiding this comment.
this large diff comes from indenting pre-existing elements in the added <fieldset> container and from making the delete button conditional to inheritance (line 154)
|
|
||
| const configWithInheritedValues = { | ||
| ...config, | ||
| ...(inheritTemplateParameters && parameterConfig ? { parameterConfig } : {}), | ||
| ...(inheritTemplateNotifications && notifications ? { notifications } : {}), | ||
| ...(inheritTemplateTriggers && triggers ? { triggers } : {}), | ||
| ...(inheritTemplateExpectedArtifacts && expectedArtifacts ? { expectedArtifacts } : {}), | ||
| ...(expectedArtifacts ? { expectedArtifacts } : {}), |
There was a problem hiding this comment.
As of this PR, inheritance of expectedArtifacts changed from opt in to always inherited. Currently only parameters, triggers, and notifications can be marked for exclusion.
| <option value="">Select...</option> | ||
| </select> | ||
| {{description}} | ||
| <fieldset ng-disabled="trigger.inherited" ng-class="{'templated-pipeline-item': trigger.inherited}"> |
There was a problem hiding this comment.
Similar to Parameter.tsx changes, much of this is shifting elements and Prettier. Inheritance related changes are on lines 3, 22-32, 55
louisjimenez
force-pushed
the
louis/mark-inherited
branch
from
a54d707
to
bbdfc27
Compare
louisjimenez
force-pushed
the
louis/mark-inherited
branch
from
05dc6ce
to
554e049
Compare
maggieneterval
approved these changes
Jun 11, 2019
|
@spinnakerbot cherry-pick 1.14 |
spinnakerbot
pushed a commit
that referenced
this pull request
Jun 11, 2019
|
Cherry pick successful: #7110 |
louisjimenez
pushed a commit
that referenced
this pull request
Jun 12, 2019
alanmquach
added a commit
to alanmquach/deck
that referenced
this pull request
Jun 18, 2019
939d608 fix(pipeline): fix invisible parameter when default is not in options (spinnaker#7125) 5c4facb fix(core/pipeline): stop searching stage context, being greedy about parentExecutions (spinnaker#7127) 8fe74bc fix(core): do not inject default execution window values on render (spinnaker#7122) ee6fbe0 fix(core/pipeline): use correct visibility default for stage durations (spinnaker#7121) c88234c refactor(stages): Fixed alias matching, added fallback and unit tests (spinnaker#7080) c358801 refactor(core): Reactify ExecutionWindows component (spinnaker#7113) 744123d fix(artifact): use artifact icons in server group link (spinnaker#7118) b8aebd7 fix(forms): Fixed SpelText not firing onChange upon autocomplete (spinnaker#7114) 4e2f749 refactor(core): reactify overrideFailure component (spinnaker#7107) 4f07aeb fix(core): Make template table list scrollable (spinnaker#7111) e5d6115 fix(core): Display template inherited items (mptv2) as read only (spinnaker#7102)
anotherchrisberry
pushed a commit
that referenced
this pull request
Jun 18, 2019
939d608 fix(pipeline): fix invisible parameter when default is not in options (#7125) 5c4facb fix(core/pipeline): stop searching stage context, being greedy about parentExecutions (#7127) 8fe74bc fix(core): do not inject default execution window values on render (#7122) ee6fbe0 fix(core/pipeline): use correct visibility default for stage durations (#7121) c88234c refactor(stages): Fixed alias matching, added fallback and unit tests (#7080) c358801 refactor(core): Reactify ExecutionWindows component (#7113) 744123d fix(artifact): use artifact icons in server group link (#7118) b8aebd7 fix(forms): Fixed SpelText not firing onChange upon autocomplete (#7114) 4e2f749 refactor(core): reactify overrideFailure component (#7107) 4f07aeb fix(core): Make template table list scrollable (#7111) e5d6115 fix(core): Display template inherited items (mptv2) as read only (#7102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPTv1 saved inherited items (notifications, triggers, parameters) directly to the pipeline config which allowed them to be displayed while configuring in deck. MPTv2 pipelines saved in spin do not save them to the pipeline config and instead rely on them being inherited during the plan phase. This PR renders items inherited from the plan and marks them as read only since they cannot be edited or deleted directly through the pipeline config.
spinnaker/spinnaker#4451
Inherited Trigger
Inherited Notification
Inherited Parameter
