fix(core/pipeline): use correct visibility default for stage durations #7121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that even though we've had stage durations configured as visible by default (i.e. opt-out), the funky business of object extending/spreading led to a false-y default (opt-in).
There's a tricky order of importance for cached values when it comes to
showDurations
— we want to override the configured defaults with cached app settings for everything except that field, which we'd like to get from the global cache. The way that global override was implemented led to us explicitly overriding the default (true
) with the globally cached value, and in the absence of cached data that means we'd end up withundefined
(false-y).