fix(google): allow SpEL in stack/detail in deploy stage #7105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@plumpy Not sure why I can't add you as a reviewer 😭 |
anotherchrisberry
approved these changes
Jun 11, 2019
|
@spinnakerbot cherry-pick 1.14 |
spinnakerbot
pushed a commit
that referenced
this pull request
Jun 11, 2019
|
Cherry pick successful: #7106 |
maggieneterval
pushed a commit
that referenced
this pull request
Jun 11, 2019
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jul 3, 2019
cdd6f23 chore(package): Just Update Prettier™ 5cc4146 perf(google): avoid unnecessary fetching and filtering of gce images (spinnaker#7115) 92492c4 fix(google): allow SpEL in stack/detail in deploy stage (spinnaker#7105) 94dc56d fix(google): Help text on GCE load balancer type selection screen (spinnaker#7044)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes spinnaker/spinnaker#4324
command.viewState.templatingEnabled = truein deploy state initialization methods shared by other providers but not by GCE, so previously we were incorrectly disallowing SpEL in stack/detail fields in Deploy stages.