Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(google): avoid unnecessary fetching and filtering of gce images #7115

Merged
merged 1 commit into from Jun 13, 2019
Merged

perf(google): avoid unnecessary fetching and filtering of gce images #7115

merged 1 commit into from Jun 13, 2019

Conversation

maggieneterval
Copy link
Contributor

@maggieneterval maggieneterval commented Jun 13, 2019 •
edited

Addresses spinnaker/spinnaker#4510

  • [perf] Removes unnecessary client-side alphabetization of image names: Clouddriver already alphabetizes image results here.
  • [perf] Removes client-side filtration of images by account; adds account as image request parameter.
  • [ux enhancement] Filters options by search text in image select dropdowns rather than only highlighting the matching text without actually removing non-matching options.
  • [perf] Since we have already fetched all available account images to populate the persistent disk configuration, do not re-fetch images for Basic Settings component. Also do not re-fetch images as user types a search query; rely on client-side filtration only.

Upcoming work: server-side performance enhancements

@maggieneterval
Copy link
Contributor Author

cc @plumpy 😸

duftler
duftler approved these changes Jun 13, 2019
View reviewed changes
Copy link

@duftler duftler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
LGTM.

ezimanyi
ezimanyi approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🖼️ 🔍 📈 🎉

@maggieneterval
Copy link
Contributor Author

Updated this PR to ensure images are re-fetched when a new account is selected, and opened corresponding Clouddriver PR here: spinnaker/clouddriver#3785
😄

@maggieneterval maggieneterval merged commit 5cc4146 into spinnaker:master Jun 13, 2019
@maggieneterval maggieneterval deleted the gce-image-perf-fixes branch June 13, 2019 19:24
@christopherthielen christopherthielen mentioned this pull request Jul 3, 2019
Merged
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Jul 3, 2019
@christopherthielen
chore(google): Bump version to 0.0.7
0dd60d1 
cdd6f23 chore(package): Just Update Prettier™
5cc4146 perf(google): avoid unnecessary fetching and filtering of gce images (spinnaker#7115)
92492c4 fix(google): allow SpEL in stack/detail in deploy stage (spinnaker#7105)
94dc56d fix(google): Help text on GCE load balancer type selection screen (spinnaker#7044)
christopherthielen added a commit that referenced this pull request Jul 3, 2019
@christopherthielen
chore(google): Bump version to 0.0.7
f0546c4 
cdd6f23 chore(package): Just Update Prettier™
5cc4146 perf(google): avoid unnecessary fetching and filtering of gce images (#7115)
92492c4 fix(google): allow SpEL in stack/detail in deploy stage (#7105)
94dc56d fix(google): Help text on GCE load balancer type selection screen (#7044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezimanyi ezimanyi ezimanyi approved these changes

@duftler duftler duftler approved these changes

Assignees
No one assigned
Labels
target-release/1.15
Projects
None yet
Milestone
No milestone
4 participants
@maggieneterval @ezimanyi @duftler @spinnakerbot