fix(notifications): Fixing custom message text shape #7349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,7 +57,7 @@ export class NotificationDetails extends React.Component<INotificationDetailsPro | |||
| if (whenOption !== 'manualJudgment' && ['email', 'slack', 'googlechat'].includes(type)) { | |||
| return ( | |||
| <FormikFormField | |||
| name={'message.' + whenOption + '.text'} | |||
| name={'message["' + whenOption + '"].text'} | |||
There was a problem hiding this comment.
nit: this may read a little more easily with a template string:
{`message["${whenOption}"].text`}
alanmquach
added a commit
to alanmquach/deck
that referenced
this pull request
Aug 20, 2019
a7896bf fix(notifications): Fixing custom message text shape (spinnaker#7349) 8bdca89 fix(core): fix vertical alignment of radio buttons (spinnaker#7344) d00f2a4 fix(artifacts): set the artifacts on trigger before the pipeline to sync problems with Angular (spinnaker#7345) b6ea1de fix(core): fix produces artifacts UI (spinnaker#7343) 9812469 feat(bakeManifest): add kustomize support (spinnaker#7342)
alanmquach
added a commit
that referenced
this pull request
Aug 20, 2019
a7896bf fix(notifications): Fixing custom message text shape (#7349) 8bdca89 fix(core): fix vertical alignment of radio buttons (#7344) d00f2a4 fix(artifacts): set the artifacts on trigger before the pipeline to sync problems with Angular (#7345) b6ea1de fix(core): fix produces artifacts UI (#7343) 9812469 feat(bakeManifest): add kustomize support (#7342)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
a7896bf fix(notifications): Fixing custom message text shape (spinnaker#7349) 8bdca89 fix(core): fix vertical alignment of radio buttons (spinnaker#7344) d00f2a4 fix(artifacts): set the artifacts on trigger before the pipeline to sync problems with Angular (spinnaker#7345) b6ea1de fix(core): fix produces artifacts UI (spinnaker#7343) 9812469 feat(bakeManifest): add kustomize support (spinnaker#7342)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Echo expects the custom message structure to be:
So we have to set the path to be
message["pipeline.starting"].textinstead ofmessage.pipeline.starting.text, which would result in: