Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Type field missing for CLB detail view #7504

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

caseyhebebrand
Copy link
Contributor

The "type" field is missing in the loadbalancer details view for CLBs.

Before:
Screen Shot 2019-10-09 at 12 24 51 PM

After:
Screen Shot 2019-10-09 at 12 25 49 PM

Copy link
Contributor

@christopherthielen christopherthielen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't even know what ipAddressTypeDescription is.

@christopherthielen christopherthielen merged commit b382a22 into spinnaker:master Oct 11, 2019
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Oct 11, 2019
b382a22 fix(ui): Type field missing for CLB detail view (spinnaker#7504)
e4e3c46 fix(amazon/loadBalancer): Disable CLB deletion if instances exist (spinnaker#7509)
christopherthielen added a commit that referenced this pull request Oct 11, 2019
b382a22 fix(ui): Type field missing for CLB detail view (#7504)
e4e3c46 fix(amazon/loadBalancer): Disable CLB deletion if instances exist (#7509)
@caseyhebebrand caseyhebebrand deleted the show-clb-type branch November 20, 2019 19:03
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
b382a22 fix(ui): Type field missing for CLB detail view (spinnaker#7504)
e4e3c46 fix(amazon/loadBalancer): Disable CLB deletion if instances exist (spinnaker#7509)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants