fix(amazon/loadBalancer): Disable CLB deletion if instances exist #7509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyhebebrand
force-pushed
the
disable-delete-clb
branch
from
0e66204
to
6d7a2a6
Compare
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Oct 11, 2019
b382a22 fix(ui): Type field missing for CLB detail view (spinnaker#7504) e4e3c46 fix(amazon/loadBalancer): Disable CLB deletion if instances exist (spinnaker#7509)
christopherthielen
added a commit
that referenced
this pull request
Oct 11, 2019
This was referenced Oct 23, 2019
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
b382a22 fix(ui): Type field missing for CLB detail view (spinnaker#7504) e4e3c46 fix(amazon/loadBalancer): Disable CLB deletion if instances exist (spinnaker#7509)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting a CLB should only be allowed when there are no instances attached to it.
This was true for ALBs and NLBs, but not for CLBs. We reference loadBalancer.instances.length to determine if deletion is enabled for the user. For CLBs, the instances array is always empty so we must rely on instance counts instead.