fix(amazon/iamRole): Do not default iamRole in deploy edit scenario #7940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigneshm
requested review from
christopherthielen,
alanmquach,
caseyhebebrand and
erikmunson
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
christopherthielen
approved these changes
Feb 24, 2020
|
@vigneshm can you rebase this and fix your commit comment? |
caseyhebebrand
approved these changes
Feb 28, 2020
alanmquach
approved these changes
Feb 29, 2020
vigneshm
changed the title
vigneshm
force-pushed
the
5272-default-iam-role
branch
2 times, most recently
from
8e45c09
to
4b7e423
Compare
|
Rebased and updated the commit message |
|
@vigneshm fwiw, the comment should start with |
Ah, my bad. |
vigneshm
changed the title
vigneshm
force-pushed
the
5272-default-iam-role
branch
from
4b7e423
to
824b80f
Compare
erikmunson
approved these changes
Mar 8, 2020
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
…t scenario (spinnaker#7940) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While editing a deploy stage without an
iamRolespecified, deck shows a default value. To the end-user, it appears that this field is set but it is empty. Fixing that in this PR so that the UI reflects the exact configuration.