feat(core/managed): use showModal API for history modal #7988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmunson
commented
Mar 1, 2020
| ModalHeader, | ||
| ModalBody, | ||
| Table, | ||
| TableRow, | ||
| TableCell, | ||
| standardGridTableLayout, | ||
| useData, | ||
| } from 'core/presentation'; | ||
| } from '../presentation'; |
There was a problem hiding this comment.
this is so that extending IModalComponentProps doesn't explode when TS can't transform the core alias in custom builds.
This was referenced Mar 1, 2020
christopherthielen
approved these changes
Mar 4, 2020
erikmunson
added
ready to merge
alanmquach
approved these changes
Mar 5, 2020
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7987
This modal really isn't tied to its parent component tree at all, and should be rendered imperatively. Implementation may change depending on the outcome of #7987