fix(pubsub): prevent NPE when retrying a pipeline execution with #8172
Conversation
a pubsub trigger
|
@Mergifyio backport release-1.18.x |
|
@Mergifyio backport release-1.19.x |
|
@danielpeach is not allowed to run commands |
1 similar comment
|
@danielpeach is not allowed to run commands |
|
@spinnakerbot cherry-pick 1.18 |
|
@spinnakerbot cherry-pick 1.19 |
|
Support for automating cherry picks is being removed from spinnakerbot in favor of the mergify backport command. To help with the transition, I'll run the required command for you now, but in the future please run the mergify command directly. |
|
@Mergifyio backport release-1.18.x |
|
Support for automating cherry picks is being removed from spinnakerbot in favor of the mergify backport command. To help with the transition, I'll run the required command for you now, but in the future please run the mergify command directly. |
|
@Mergifyio backport release-1.19.x |
a pubsub trigger (cherry picked from commit 5d95271)
|
Command
|
a pubsub trigger (cherry picked from commit 5d95271)
|
Command
|
a pubsub trigger
Retrying a pipeline with a pubsub trigger + any other trigger doesn't work because the pubsub trigger type doesn't implement a
manualExecutionComponent. Wrote out a larger description of the problem here: spinnaker/spinnaker#5682This PR "solves" the problem by preventing the retry modal from blowing up, but eventually would love to see the attached issue solved.