Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bake): adding skip region detection checkbox #8277

Merged
merged 5 commits into from
May 14, 2020
Merged

fix(bake): adding skip region detection checkbox #8277

merged 5 commits into from
May 14, 2020

Conversation

edgarulg
Copy link
Contributor

This change is related with following issue: spinnaker/spinnaker#4641
and uses the functionality provided in: spinnaker/orca#3627

This change is about adding the skip region detection checkbox to the bake stage for AWS provider.
Captura de Pantalla 2020-05-13 a la(s) 9 27 14

When a bake stage runs, orca tries to get all the regions that we use in next stages, this causes that the bake happen on different regions rather that we specified. This checkbox prevent Orca to find out regions in other stages for bake.

The default value is false, so any pipeline already defined with bake won't change its behavior.

@marchello2000
Copy link
Contributor

(seems reasonable to me, but..) I will defer to one of the deck engineers on this since my html/js/ts is effectively non-existent.

erikmunson
erikmunson reviewed May 13, 2020
View reviewed changes
Copy link
Member

@erikmunson erikmunson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small wording tweak to be consistent with the overall tone of the UI, I'd also +1 Mark's comment about adding some help text. Other than that looks great!

app/scripts/modules/amazon/src/pipeline/stages/bake/bakeStage.html Outdated Show resolved Hide resolved
@edgarulg
Copy link
Contributor Author

I took a look at your comments and made the necessary changes to improve the code.

erikmunson
erikmunson approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@erikmunson erikmunson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erikmunson erikmunson added the ready to merge Reviewed and ready for merge label May 14, 2020
@mergify mergify bot merged commit 200198f into spinnaker:master May 14, 2020
@edgarulg
Copy link
Contributor Author

@spinnakerbot cherry-pick 1.19

@spinnakerbot
Copy link
Contributor

Support for automating cherry picks is being removed from spinnakerbot in favor of the mergify backport command. To help with the transition, I'll run the required command for you now, but in the future please run the mergify command directly.

@spinnakerbot
Copy link
Contributor

@Mergifyio backport release-1.19.x

@edgarulg
Copy link
Contributor Author

@spinnakerbot cherry-pick 1.20

mergify bot pushed a commit that referenced this pull request May 14, 2020
@edgarulg
fix(bake): adding skip region detection checkbox (#8277)
2c40751 
* fix(bake): adding skip region detection checkbox.

* fix(bake): adding help-key for give more context of what the checkbox does

* fix(bake): rewrite short message.

(cherry picked from commit 200198f)
@mergify mergify bot mentioned this pull request May 14, 2020
Merged
@mergify
Copy link
Contributor

mergify bot commented May 14, 2020

Command backport release-1.19.x: success

Backports have been created

@spinnakerbot
Copy link
Contributor

Support for automating cherry picks is being removed from spinnakerbot in favor of the mergify backport command. To help with the transition, I'll run the required command for you now, but in the future please run the mergify command directly.

@spinnakerbot
Copy link
Contributor

@Mergifyio backport release-1.20.x

mergify bot pushed a commit that referenced this pull request May 14, 2020
@edgarulg
fix(bake): adding skip region detection checkbox (#8277)
7478437 
* fix(bake): adding skip region detection checkbox.

* fix(bake): adding help-key for give more context of what the checkbox does

* fix(bake): rewrite short message.

(cherry picked from commit 200198f)
@mergify mergify bot mentioned this pull request May 14, 2020
Merged
@mergify
Copy link
Contributor

mergify bot commented May 14, 2020

Command backport release-1.20.x: success

Backports have been created

mergify bot added a commit that referenced this pull request May 18, 2020
@mergify @edgarulg
fix(bake): adding skip region detection checkbox (#8277) (#8283)
59acfca 
* fix(bake): adding skip region detection checkbox.

* fix(bake): adding help-key for give more context of what the checkbox does

* fix(bake): rewrite short message.

(cherry picked from commit 200198f)

Co-authored-by: Edgar Garcia <63310723+edgarulg@users.noreply.github.com>
ethanfrogers pushed a commit that referenced this pull request May 18, 2020
@mergify
fix(bake): adding skip region detection checkbox (bp #8277) (#8284)
e0f33be
@atyutyunnik
Copy link
Contributor

shouldn't the wording be "Ensure Bake happens only in the selected regions"?

yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
@mergify
fix(bake): adding skip region detection checkbox (bp spinnaker#8277) (s…
6bd544d 
…pinnaker#8284)
@edgarulg edgarulg mentioned this pull request Nov 17, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchello2000 marchello2000 marchello2000 left review comments

@erikmunson erikmunson erikmunson approved these changes

@kevinawoo kevinawoo Awaiting requested review from kevinawoo

Assignees
No one assigned
Labels
ready to merge Reviewed and ready for merge target-release/1.21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edgarulg @marchello2000 @spinnakerbot @atyutyunnik @erikmunson