refactor(instance): Migrate the instance chiclet tooltip from raw bootstrap to Tooltip component #8437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tstrap to Tooltip component This commit includes a performance optimization where tooltips are only shown after the chiclet has been hovered. Otherwise, the Tooltip causes massive lag n screens with large number of instances. This happens when scrolling due to virtualized scrolling and the overhad of the mount/unmount cycle.
christopherthielen
requested review from
vigneshm,
erikmunson and
caseyhebebrand
vigneshm
approved these changes
Jul 30, 2020
christopherthielen
deleted the
migrate-instance-component-tooltip-to-react-bootstrap
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes a performance optimization where tooltips are only shown after the chiclet has been hovered. Otherwise, the Tooltip causes massive lag on screens with large number of instances. This happens when scrolling due to virtualized scrolling and the overhad of the mount/unmount cycle.