Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/managed): fixup some details from new layout #8619

Merged
merged 3 commits into from
Oct 3, 2020

Conversation

erikmunson
Copy link
Member

Cleaning up a couple one-line messes I made with some previous PRs:

  • There's a 1px border on the 'inactive' status bubble now, which was making it 2px bigger in diameter than other bubbles and causing some layout jank when switching between versions. Removed a pixel of padding to compensate
  • When relative timestamps grow to three characters (e.g. 21d) they're busting out of the minimum width of the timestamp column on status cards, which leads to text misalignment. I explicitly chose to be ok with that for timestamps that cross into the longer format (e.g. Jan 28) for now, but I'm bumping the minimum width so that any abbreviated timestamps retain the standard column size

cc @gcomstock

@erikmunson erikmunson merged commit abffd84 into spinnaker:master Oct 3, 2020
@erikmunson erikmunson deleted the md-env-detail-fixes branch October 3, 2020 00:00
erikmunson pushed a commit that referenced this pull request Oct 5, 2020
80858e7 feat(core/managed): limit artifact versions to 30 (#8623)
90a2819 feat(core/managed): put constraints in a 'skipped' state on skipped versions (#8620)
815742d feat(core/managed): scroll to selected version in sidebar, update scroll containers (#8618)
de24ef3 feat(core/managed): apply consistent sorting to resources (#8622)
3735483 fix(core/pipeline): Always enable "show revision history" in edit pipeline dialog (#8621)
abffd84 fix(core/managed): fixup some details from new layout (#8619)
f1bb04e fix(appname): encodeURIComponent for app name (#8586)
60c0c7b feat(validation): Allow app name validators to be overridden (#8584)
mergify bot pushed a commit that referenced this pull request Oct 5, 2020
…e@0.0.516 docker@0.0.60 google@0.0.21 oracle@0.0.9 tencentcloud@0.0.6 (#8624)

* chore(amazon): publish amazon@0.0.269

f1bb04e fix(appname): encodeURIComponent for app name (#8586)

* chore(azure): publish azure@0.0.255

f1bb04e fix(appname): encodeURIComponent for app name (#8586)

* chore(cloudfoundry): publish cloudfoundry@0.0.101

f1bb04e fix(appname): encodeURIComponent for app name (#8586)

* chore(core): publish core@0.0.516

80858e7 feat(core/managed): limit artifact versions to 30 (#8623)
90a2819 feat(core/managed): put constraints in a 'skipped' state on skipped versions (#8620)
815742d feat(core/managed): scroll to selected version in sidebar, update scroll containers (#8618)
de24ef3 feat(core/managed): apply consistent sorting to resources (#8622)
3735483 fix(core/pipeline): Always enable "show revision history" in edit pipeline dialog (#8621)
abffd84 fix(core/managed): fixup some details from new layout (#8619)
f1bb04e fix(appname): encodeURIComponent for app name (#8586)
60c0c7b feat(validation): Allow app name validators to be overridden (#8584)

* chore(docker): publish docker@0.0.60

f1bb04e fix(appname): encodeURIComponent for app name (#8586)

* chore(google): publish google@0.0.21

f1bb04e fix(appname): encodeURIComponent for app name (#8586)

* chore(oracle): publish oracle@0.0.9

f1bb04e fix(appname): encodeURIComponent for app name (#8586)

* chore(tencentcloud): publish tencentcloud@0.0.6

f1bb04e fix(appname): encodeURIComponent for app name (#8586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants